Chromium Code Reviews| Index: webrtc/logging/BUILD.gn |
| diff --git a/webrtc/logging/BUILD.gn b/webrtc/logging/BUILD.gn |
| index 0cf5731bbc6474852d4c767b4b14dc6df6d3ffca..37894477bc8258edf0aa0b051e518b17289f6891 100644 |
| --- a/webrtc/logging/BUILD.gn |
| +++ b/webrtc/logging/BUILD.gn |
| @@ -23,18 +23,13 @@ group("logging") { |
| } |
| rtc_source_set("rtc_event_log_api") { |
| - # TODO(kjellander): Remove (bugs.webrtc.org/7257) |
| - # Enabling GN check triggers cyclic dependency error: |
| - # //webrtc/logging:rtc_event_log_api -> |
| - # //webrtc/modules/audio_coding:audio_network_adaptor -> |
| - # //webrtc/logging:rtc_event_log_api |
| - check_includes = false |
| sources = [ |
| "rtc_event_log/rtc_event_log.h", |
| ] |
| deps = [ |
| "../base:rtc_base_approved", |
| "../call:call_interfaces", |
| + "../modules/remote_bitrate_estimator:remote_bitrate_estimator", |
|
terelius
2017/04/06 09:39:37
I don't like this. The event log API should not li
|
| ] |
| } |
| @@ -87,6 +82,7 @@ if (rtc_enable_protobuf) { |
| ":rtc_event_log_proto", |
| "..:webrtc_common", |
| "../call:call_interfaces", |
| + "../modules/audio_coding:audio_network_adaptor", |
| "../modules/rtp_rtcp:rtp_rtcp", |
| "../system_wrappers", |
| ] |
| @@ -114,6 +110,7 @@ if (rtc_enable_protobuf) { |
| "../base:rtc_base_approved", |
| "../base:rtc_base_tests_utils", |
| "../call", |
| + "../modules/audio_coding:audio_network_adaptor", |
| "../modules/rtp_rtcp", |
| "../system_wrappers:metrics_default", |
| "../test:test_support", |