webrtc/modules/audio_coding/audio_network_adaptor/fec_controller_plr_based_unittest.cc - Issue 2745473003: Resolve cyclic dependency between audio network adaptor and event log api

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/audio_network_adaptor/fec_controller_plr_based_unittest.cc

Issue 2745473003: Resolve cyclic dependency between audio network adaptor and event log api (Closed)

Patch Set: Activated checks for rtc_event_log_api Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/logging/BUILD.gn ('K') | « webrtc/modules/audio_coding/audio_network_adaptor/fec_controller_plr_based.cc ('k') | webrtc/modules/audio_coding/audio_network_adaptor/fec_controller_rplr_based.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/audio_network_adaptor/fec_controller_plr_based_unittest.cc

diff --git a/webrtc/modules/audio_coding/audio_network_adaptor/fec_controller_plr_based_unittest.cc b/webrtc/modules/audio_coding/audio_network_adaptor/fec_controller_plr_based_unittest.cc

index 34f16c82729129061715d0f2280420517bf20f0d..3dc79d18d06e466de0db5241cb023ec28a363023 100644

--- a/webrtc/modules/audio_coding/audio_network_adaptor/fec_controller_plr_based_unittest.cc

+++ b/webrtc/modules/audio_coding/audio_network_adaptor/fec_controller_plr_based_unittest.cc

@@ -97,7 +97,7 @@ void UpdateNetworkMetrics(FecControllerPlrBasedTestStates* states,

void CheckDecision(FecControllerPlrBasedTestStates* states,

bool expected_enable_fec,

float expected_uplink_packet_loss_fraction) {

- AudioNetworkAdaptor::EncoderRuntimeConfig config;

+ AudioEncoderRuntimeConfig config;

states->controller->MakeDecision(&config);

EXPECT_EQ(rtc::Optional<bool>(expected_enable_fec), config.enable_fec);

EXPECT_EQ(rtc::Optional<float>(expected_uplink_packet_loss_fraction),