webrtc/modules/audio_coding/audio_network_adaptor/bitrate_controller.cc - Issue 2745473003: Resolve cyclic dependency between audio network adaptor and event log api

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/audio_network_adaptor/bitrate_controller.cc

Issue 2745473003: Resolve cyclic dependency between audio network adaptor and event log api (Closed)

Patch Set: Activated checks for rtc_event_log_api Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/logging/BUILD.gn ('K') | « webrtc/modules/audio_coding/audio_network_adaptor/bitrate_controller.h ('k') | webrtc/modules/audio_coding/audio_network_adaptor/bitrate_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/audio_network_adaptor/bitrate_controller.cc

diff --git a/webrtc/modules/audio_coding/audio_network_adaptor/bitrate_controller.cc b/webrtc/modules/audio_coding/audio_network_adaptor/bitrate_controller.cc

index d8c74cd3ca60ac602ef5e77644d81c5664a474b5..92a9fada468c33d07e4ad0138c522f7020f2299e 100644

--- a/webrtc/modules/audio_coding/audio_network_adaptor/bitrate_controller.cc

+++ b/webrtc/modules/audio_coding/audio_network_adaptor/bitrate_controller.cc

@@ -43,8 +43,7 @@ void BitrateController::UpdateNetworkMetrics(

overhead_bytes_per_packet_ = network_metrics.overhead_bytes_per_packet;

}

-void BitrateController::MakeDecision(

- AudioNetworkAdaptor::EncoderRuntimeConfig* config) {

+void BitrateController::MakeDecision(AudioEncoderRuntimeConfig* config) {

// Decision on |bitrate_bps| should not have been made.

RTC_DCHECK(!config->bitrate_bps);

if (target_audio_bitrate_bps_ && overhead_bytes_per_packet_) {