Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Issue 2745253007: (Re)move VoE specific enums from common_types.h. (Closed)

Created:
3 years, 9 months ago by the sun
Modified:
3 years, 9 months ago
Reviewers:
kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, yujie_mao (webrtc), tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, the sun
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

(Re)move VoE specific enums from common_types.h. BUG=webrtc:5876 Review-Url: https://codereview.webrtc.org/2745253007 Cr-Commit-Position: refs/heads/master@{#17267} Committed: https://chromium.googlesource.com/external/webrtc/+/22818a580424c17a964026ecdf20231d5c582a06

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -85 lines) Patch
M webrtc/common_types.h View 1 chunk +0 lines, -62 lines 0 comments Download
M webrtc/media/engine/apm_helpers.h View 2 chunks +12 lines, -4 lines 0 comments Download
M webrtc/media/engine/apm_helpers.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M webrtc/media/engine/apm_helpers_unittest.cc View 1 chunk +4 lines, -8 lines 0 comments Download
M webrtc/media/engine/webrtcvoiceengine.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/media/engine/webrtcvoiceengine.cc View 3 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
the sun
3 years, 9 months ago (2017-03-15 15:51:09 UTC) #2
kwiberg-webrtc
lgtm
3 years, 9 months ago (2017-03-16 01:11:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2745253007/1
3 years, 9 months ago (2017-03-16 07:02:26 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 08:20:29 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/22818a580424c17a964026ecd...

Powered by Google App Engine
This is Rietveld 408576698