Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 2745073004: Delete unused Pathname methods. (Closed)

Created:
3 years, 9 months ago by nisse-webrtc
Modified:
3 years, 9 months ago
Reviewers:
pthatcher, pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete unused Pathname methods. BUG=webrtc:6424 Review-Url: https://codereview.webrtc.org/2745073004 Cr-Commit-Position: refs/heads/master@{#17388} Committed: https://chromium.googlesource.com/external/webrtc/+/0be49d8d1028a2eb3aafd979091cfa0311e6c3c3

Patch Set 1 #

Patch Set 2 : Add back Pathname::clear, it's used in the windows code. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -72 lines) Patch
M webrtc/base/pathutils.h View 1 2 chunks +0 lines, -18 lines 0 comments Download
M webrtc/base/pathutils.cc View 1 5 chunks +0 lines, -54 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
nisse-webrtc
PTAL. Implementation could be simplified too, but this just cuts down a bit on the ...
3 years, 9 months ago (2017-03-24 12:16:32 UTC) #2
pthatcher1
lgtm
3 years, 9 months ago (2017-03-25 04:34:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2745073004/20001
3 years, 9 months ago (2017-03-27 11:34:53 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-27 11:37:20 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/0be49d8d1028a2eb3aafd9790...

Powered by Google App Engine
This is Rietveld 408576698