Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2744953003: Remove VoENetEqStats interface. (Closed)

Created:
3 years, 9 months ago by the sun
Modified:
3 years, 9 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, AleBzk, henrika_webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove VoENetEqStats interface. (TBR stefan@ for changes to webrtc/test/mock_voice_engine.h) BUG=webrtc:4690 TBR=stefan@webrtc.org Review-Url: https://codereview.webrtc.org/2744953003 Cr-Commit-Position: refs/heads/master@{#17201} Committed: https://chromium.googlesource.com/external/webrtc/+/c6192a9e3207cd3c2815939c9c6a68cbf97905de

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Patch Set 3 : Comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -254 lines) Patch
M webrtc/test/mock_voice_engine.h View 1 chunk +0 lines, -6 lines 0 comments Download
M webrtc/voice_engine/BUILD.gn View 3 chunks +0 lines, -4 lines 0 comments Download
M webrtc/voice_engine/channel.h View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
D webrtc/voice_engine/include/voe_neteq_stats.h View 1 chunk +0 lines, -49 lines 0 comments Download
M webrtc/voice_engine/test/auto_test/fixtures/before_initialization_fixture.h View 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/voice_engine/test/auto_test/fixtures/before_initialization_fixture.cc View 2 chunks +0 lines, -2 lines 0 comments Download
D webrtc/voice_engine/test/auto_test/standard/neteq_stats_test.cc View 1 chunk +0 lines, -59 lines 0 comments Download
M webrtc/voice_engine/test/auto_test/voe_standard_test.h View 2 chunks +1 line, -3 lines 0 comments Download
M webrtc/voice_engine/test/auto_test/voe_standard_test.cc View 3 chunks +0 lines, -5 lines 0 comments Download
M webrtc/voice_engine/test/auto_test/voe_test_defines.h View 1 chunk +0 lines, -3 lines 0 comments Download
D webrtc/voice_engine/voe_neteq_stats_impl.h View 1 chunk +0 lines, -38 lines 0 comments Download
D webrtc/voice_engine/voe_neteq_stats_impl.cc View 1 chunk +0 lines, -77 lines 0 comments Download
M webrtc/voice_engine/voice_engine_impl.h View 3 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
the sun
3 years, 9 months ago (2017-03-11 19:52:49 UTC) #4
hlundin-webrtc
LGTM with one comment. https://codereview.webrtc.org/2744953003/diff/1/webrtc/voice_engine/channel.h File webrtc/voice_engine/channel.h (right): https://codereview.webrtc.org/2744953003/diff/1/webrtc/voice_engine/channel.h#newcode252 webrtc/voice_engine/channel.h:252: // TODO(solenberg): Todo what?
3 years, 9 months ago (2017-03-13 08:36:38 UTC) #7
the sun
https://codereview.webrtc.org/2744953003/diff/1/webrtc/voice_engine/channel.h File webrtc/voice_engine/channel.h (right): https://codereview.webrtc.org/2744953003/diff/1/webrtc/voice_engine/channel.h#newcode252 webrtc/voice_engine/channel.h:252: // TODO(solenberg): On 2017/03/13 08:36:38, hlundin-webrtc wrote: > Todo ...
3 years, 9 months ago (2017-03-13 08:52:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2744953003/40001
3 years, 9 months ago (2017-03-13 08:52:18 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/14809)
3 years, 9 months ago (2017-03-13 08:56:49 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2744953003/40001
3 years, 9 months ago (2017-03-13 09:06:27 UTC) #16
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 09:36:23 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/c6192a9e3207cd3c2815939c9...

Powered by Google App Engine
This is Rietveld 408576698