Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 2744833002: Delete utf_util_win.h. (Closed)

Created:
3 years, 9 months ago by nisse-webrtc
Modified:
3 years, 9 months ago
CC:
webrtc-reviews_webrtc.org, henrika_webrtc, zhengzhonghou_agora.io, tterriberry_mozilla.com, fengyue_agora.io, peah-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete utf_util_win.h. It duplicates base/win32.h. BUG=None Review-Url: https://codereview.webrtc.org/2744833002 Cr-Commit-Position: refs/heads/master@{#17221} Committed: https://chromium.googlesource.com/external/webrtc/+/07b8388234624c31aad7a7f4f5be2ecb2ee76ff8

Patch Set 1 #

Patch Set 2 : Add rtc:: prefix to ToUtf16 and ToUtf8. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -63 lines) Patch
M webrtc/system_wrappers/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D webrtc/system_wrappers/include/utf_util_win.h View 1 chunk +0 lines, -58 lines 0 comments Download
M webrtc/test/testsupport/fileutils.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
nisse-webrtc
PTAL.
3 years, 9 months ago (2017-03-10 13:43:54 UTC) #2
kjellander_webrtc
lgtm, thanks for cleaning this up for me. Back when this was done this code ...
3 years, 9 months ago (2017-03-10 13:50:29 UTC) #5
Henrik Grunell WebRTC
lgtm Sorry for the slow response - been sick.
3 years, 9 months ago (2017-03-14 08:04:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2744833002/20001
3 years, 9 months ago (2017-03-14 08:14:16 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 08:32:54 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/07b8388234624c31aad7a7f4f...

Powered by Google App Engine
This is Rietveld 408576698