Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2744823002:
Fix perf test regression for screenshare and vp9. (Closed)
|
Created:
3 years, 9 months ago by sprang_webrtc Modified:
3 years, 9 months ago Reviewers:
ilnik CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionFix perf test regression for screenshare and vp9.
Turns out temporal_layer_thresholds_bps doesn't work quite as expected.
It's for instance not honored at all for normal VP8 video. We need to
take a pass over this in general.
BUG=chromium:700297
Review-Url: https://codereview.webrtc.org/2744823002
Cr-Commit-Position: refs/heads/master@{#17199}
Committed: https://chromium.googlesource.com/external/webrtc/+/6ef1b34aae1bcd02ed261ebc5daab14cc4b8db1b
Patch Set 1 #Patch Set 2 : 3tl fix #
Total comments: 2
Patch Set 3 : Revert to old behavior #Messages
Total messages: 18 (12 generated)
sprang@webrtc.org changed reviewers: + ilnik@webrtc.org
The CQ bit was checked by sprang@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_baremetal on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_baremetal/builds/...)
The CQ bit was checked by sprang@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
https://codereview.webrtc.org/2744823002/diff/20001/webrtc/video/video_qualit... File webrtc/video/video_quality_test.cc (right): https://codereview.webrtc.org/2744823002/diff/20001/webrtc/video/video_qualit... webrtc/video/video_quality_test.cc:1173: // Hack for VP8 screenshare_layers. We have a VP8 simulcast tests with 3 temporal layers. Will it work there? Alternatevely, we have VP9 with 2TL. there will be no temporal_layer_thresholds_bps in that case. Is it intended?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_baremetal on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_baremetal/builds/...)
https://codereview.webrtc.org/2744823002/diff/20001/webrtc/video/video_qualit... File webrtc/video/video_quality_test.cc (right): https://codereview.webrtc.org/2744823002/diff/20001/webrtc/video/video_qualit... webrtc/video/video_quality_test.cc:1173: // Hack for VP8 screenshare_layers. On 2017/03/10 13:43:39, ilnik wrote: > We have a VP8 simulcast tests with 3 temporal layers. Will it work there? > Alternatevely, we have VP9 with 2TL. there will be no > temporal_layer_thresholds_bps in that case. Is it intended? Dammit. These settings are dcheck'd but not honored. :( Reverted to old behavior.
On 2017/03/10 15:50:55, språng wrote: > https://codereview.webrtc.org/2744823002/diff/20001/webrtc/video/video_qualit... > File webrtc/video/video_quality_test.cc (right): > > https://codereview.webrtc.org/2744823002/diff/20001/webrtc/video/video_qualit... > webrtc/video/video_quality_test.cc:1173: // Hack for VP8 screenshare_layers. > On 2017/03/10 13:43:39, ilnik wrote: > > We have a VP8 simulcast tests with 3 temporal layers. Will it work there? > > Alternatevely, we have VP9 with 2TL. there will be no > > temporal_layer_thresholds_bps in that case. Is it intended? > > Dammit. These settings are dcheck'd but not honored. :( > Reverted to old behavior. lgtm.
The CQ bit was checked by sprang@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489394575725520,
"parent_rev": "382a72a0d321f19ac9cdc9bb30712cefe2639f88", "commit_rev":
"6ef1b34aae1bcd02ed261ebc5daab14cc4b8db1b"}
Message was sent while issue was closed.
Description was changed from ========== Fix perf test regression for screenshare and vp9. Turns out temporal_layer_thresholds_bps doesn't work quite as expected. It's for instance not honored at all for normal VP8 video. We need to take a pass over this in general. BUG=chromium:700297 ========== to ========== Fix perf test regression for screenshare and vp9. Turns out temporal_layer_thresholds_bps doesn't work quite as expected. It's for instance not honored at all for normal VP8 video. We need to take a pass over this in general. BUG=chromium:700297 Review-Url: https://codereview.webrtc.org/2744823002 Cr-Commit-Position: refs/heads/master@{#17199} Committed: https://chromium.googlesource.com/external/webrtc/+/6ef1b34aae1bcd02ed261ebc5... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/external/webrtc/+/6ef1b34aae1bcd02ed261ebc5... |
