Don't report perf metrics for packet loss ramp-up tests.

Don't report perf metrics for packet loss ramp-up tests.

BUG=chromium:699072
Review-Url: https://codereview.webrtc.org/2744603002
Cr-Commit-Position: refs/heads/master@{#17145}
Committed: https://chromium.googlesource.com/external/webrtc/+/45b5fe549f9bea7a4abc9932937b6c35ad5adc54

[stefan-webrtc, 2017-03-09 11:49:03]

stefan@webrtc.org changed reviewers:
+ philipel@webrtc.org

[philipel, 2017-03-09 13:59:56]

lgtm with one comment.

https://codereview.webrtc.org/2744603002/diff/1/webrtc/call/rampup_tests.h
File webrtc/call/rampup_tests.h (right):

https://codereview.webrtc.org/2744603002/diff/1/webrtc/call/rampup_tests.h#ne...
webrtc/call/rampup_tests.h:74: const bool report_perf_stats_;
After some offline discussion we concluded that some of these tests do not
belong in the webrtc_perf_tests binary, but it requires some refactoring to move
them to a new one.

Maybe create a bug and link to it from here with a TODO?

[stefan-webrtc, 2017-03-09 14:03:58]

https://codereview.webrtc.org/2744603002/diff/1/webrtc/call/rampup_tests.h
File webrtc/call/rampup_tests.h (right):

https://codereview.webrtc.org/2744603002/diff/1/webrtc/call/rampup_tests.h#ne...
webrtc/call/rampup_tests.h:74: const bool report_perf_stats_;
On 2017/03/09 13:59:56, philipel wrote:
> After some offline discussion we concluded that some of these tests do not
> belong in the webrtc_perf_tests binary, but it requires some refactoring to
move
> them to a new one.
> 
> Maybe create a bug and link to it from here with a TODO?

Done.

[stefan-webrtc, 2017-03-09 14:04:03]

The CQ bit was checked by stefan@webrtc.org

[stefan-webrtc, 2017-03-09 14:04:03]

The patchset sent to the CQ was uploaded after l-g-t-m from philipel@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2744603002/#ps20001 (title:
"Add comment.")

[commit-bot: I haz the power, 2017-03-09 14:04:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-09 14:27:04]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489068243453340,
"parent_rev": "67fdb80837eca3e48445cc3e80dcee86d144096e", "commit_rev":
"45b5fe549f9bea7a4abc9932937b6c35ad5adc54"}

[commit-bot: I haz the power, 2017-03-09 14:27:06]

Description was changed from

==========
Don't report perf metrics for packet loss ramp-up tests.

BUG=chromium:699072
==========

to

==========
Don't report perf metrics for packet loss ramp-up tests.

BUG=chromium:699072

Review-Url: https://codereview.webrtc.org/2744603002
Cr-Commit-Position: refs/heads/master@{#17145}
Committed:
https://chromium.googlesource.com/external/webrtc/+/45b5fe549f9bea7a4abc99329...
==========

[commit-bot: I haz the power, 2017-03-09 14:27:07]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/45b5fe549f9bea7a4abc99329...