Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 2744603002: Don't report perf metrics for packet loss ramp-up tests. (Closed)

Created:
3 years, 9 months ago by stefan-webrtc
Modified:
3 years, 9 months ago
Reviewers:
philipel
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Don't report perf metrics for packet loss ramp-up tests. BUG=chromium:699072 Review-Url: https://codereview.webrtc.org/2744603002 Cr-Commit-Position: refs/heads/master@{#17145} Committed: https://chromium.googlesource.com/external/webrtc/+/45b5fe549f9bea7a4abc9932937b6c35ad5adc54

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -22 lines) Patch
M webrtc/call/rampup_tests.h View 3 chunks +3 lines, -2 lines 0 comments Download
M webrtc/call/rampup_tests.cc View 1 10 chunks +29 lines, -20 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
stefan-webrtc
3 years, 9 months ago (2017-03-09 11:49:04 UTC) #2
philipel
lgtm with one comment. https://codereview.webrtc.org/2744603002/diff/1/webrtc/call/rampup_tests.h File webrtc/call/rampup_tests.h (right): https://codereview.webrtc.org/2744603002/diff/1/webrtc/call/rampup_tests.h#newcode74 webrtc/call/rampup_tests.h:74: const bool report_perf_stats_; After some ...
3 years, 9 months ago (2017-03-09 13:59:56 UTC) #3
stefan-webrtc
https://codereview.webrtc.org/2744603002/diff/1/webrtc/call/rampup_tests.h File webrtc/call/rampup_tests.h (right): https://codereview.webrtc.org/2744603002/diff/1/webrtc/call/rampup_tests.h#newcode74 webrtc/call/rampup_tests.h:74: const bool report_perf_stats_; On 2017/03/09 13:59:56, philipel wrote: > ...
3 years, 9 months ago (2017-03-09 14:03:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2744603002/20001
3 years, 9 months ago (2017-03-09 14:04:07 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 14:27:07 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/45b5fe549f9bea7a4abc99329...

Powered by Google App Engine
This is Rietveld 408576698