Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 2744233002: Provide default impl of TimeUntilNextProcess in MockRtpRtcp instead of mocking. (Closed)

Created:
3 years, 9 months ago by tommi
Modified:
3 years, 9 months ago
Reviewers:
mflodman
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Provide default impl of TimeUntilNextProcess in MockRtpRtcp instead of mocking. This method isn't currently mocked or required by any test, so the safe thing is to return a reasonably large value from the implementation to avoid busy loops. BUG=webrtc:7187 TBR=mflodman@webrtc.org Review-Url: https://codereview.webrtc.org/2744233002 Cr-Commit-Position: refs/heads/master@{#17284} Committed: https://chromium.googlesource.com/external/webrtc/+/994ebb47024e7bf7e65039384a48a9854011d283

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M webrtc/modules/rtp_rtcp/mocks/mock_rtp_rtcp.h View 3 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 16 (11 generated)
tommi
3 years, 9 months ago (2017-03-13 10:59:48 UTC) #2
tommi
magnus - can you take a look?
3 years, 9 months ago (2017-03-14 18:45:27 UTC) #9
tommi
TBR-ing as there is no test handling this right now.
3 years, 9 months ago (2017-03-17 10:32:06 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2744233002/1
3 years, 9 months ago (2017-03-17 10:32:18 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 11:01:37 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/994ebb47024e7bf7e65039384...

Powered by Google App Engine
This is Rietveld 408576698