Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2744213002: Remove dead test code and fix usage print-out for other tests (Closed)

Created:
3 years, 9 months ago by hlundin-webrtc
Modified:
3 years, 9 months ago
Reviewers:
kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, kwiberg-webrtc, minyue-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove dead test code and fix usage print-out for other tests BUG=none Review-Url: https://codereview.webrtc.org/2744213002 Cr-Commit-Position: refs/heads/master@{#17204} Committed: https://chromium.googlesource.com/external/webrtc/+/a2b2f6fe96b7efc7cb1917752307a839ba84861e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -632 lines) Patch
M webrtc/modules/audio_coding/codecs/isac/fix/test/kenny.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D webrtc/modules/audio_coding/codecs/isac/fix/test/test_iSACfixfloat.c View 1 chunk +0 lines, -629 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/main/test/ReleaseTest-API/ReleaseTest-API.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
hlundin-webrtc
ptal
3 years, 9 months ago (2017-03-13 09:16:13 UTC) #2
kwiberg-webrtc
lgtm Do we have any non-fossil tests for iSAC float/fix interop?
3 years, 9 months ago (2017-03-13 09:46:53 UTC) #3
hlundin-webrtc
On 2017/03/13 09:46:53, kwiberg-webrtc wrote: > lgtm > > Do we have any non-fossil tests ...
3 years, 9 months ago (2017-03-13 10:31:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2744213002/1
3 years, 9 months ago (2017-03-13 10:31:56 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 11:39:37 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/a2b2f6fe96b7efc7cb1917752...

Powered by Google App Engine
This is Rietveld 408576698