Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2743933004: Unify the FillAudioEncoderTimeSeries with existing processing functions. (Closed)

Created:
3 years, 9 months ago by terelius
Modified:
3 years, 9 months ago
Reviewers:
michaelt
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Unify the FillAudioEncoderTimeSeries with existing processing functions. Use lambdas instead of function objects. BUG=webrtc:7323 Review-Url: https://codereview.webrtc.org/2743933004 Cr-Commit-Position: refs/heads/master@{#17208} Committed: https://chromium.googlesource.com/external/webrtc/+/53dc23c28f6a4cc89065e41b6db51a5d81cd7954

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+198 lines, -176 lines) Patch
M webrtc/tools/event_log_visualizer/analyzer.h View 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/tools/event_log_visualizer/analyzer.cc View 11 chunks +198 lines, -171 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
terelius
Hi Michael! Mixing function objects and lambdas feel a bit inconsistent to me. I made ...
3 years, 9 months ago (2017-03-10 15:00:51 UTC) #2
michaelt
Nice, this is probably the better solution that mine fancy "function objects and lambdas template ...
3 years, 9 months ago (2017-03-13 09:30:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2743933004/1
3 years, 9 months ago (2017-03-13 11:57:38 UTC) #5
terelius
On 2017/03/13 09:30:47, michaelt wrote: > Nice, this is probably the better solution that mine ...
3 years, 9 months ago (2017-03-13 12:04:39 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 12:24:12 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/53dc23c28f6a4cc89065e41b6...

Powered by Google App Engine
This is Rietveld 408576698