Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Issue 2743653005: Fixed invalid filtering of SCTP datachannel packets on high ports. (Closed)

Created:
3 years, 9 months ago by joachim
Modified:
3 years, 9 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fixed invalid filtering of SCTP datachannel packets on high ports. Packets on source ports 32768-49151 got identified as RTP packets by "IsRtpPacket" and were ignored by the SCTP transport. This CL changes this to check the packet flags for "PF_SRTP_BYPASS". BUG=webrtc:6959 Review-Url: https://codereview.webrtc.org/2743653005 Cr-Commit-Position: refs/heads/master@{#17179} Committed: https://chromium.googlesource.com/external/webrtc/+/46d2457debb617b5ff4dfdbe61e3c637b9fb787b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -6 lines) Patch
M webrtc/media/sctp/sctptransport.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M webrtc/media/sctp/sctptransport_unittest.cc View 3 chunks +20 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
joachim
Ptal
3 years, 9 months ago (2017-03-10 00:21:26 UTC) #2
Taylor Brandstetter
lgtm
3 years, 9 months ago (2017-03-10 06:22:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2743653005/1
3 years, 9 months ago (2017-03-10 06:40:25 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/14685)
3 years, 9 months ago (2017-03-10 06:44:55 UTC) #7
Taylor Brandstetter
On 2017/03/10 06:44:55, commit-bot: I haz the power wrote: > Try jobs failed on following ...
3 years, 9 months ago (2017-03-10 07:02:15 UTC) #8
joachim
+pthatcher for owner review. Ptal.
3 years, 9 months ago (2017-03-10 07:25:10 UTC) #10
pthatcher1
lgtm
3 years, 9 months ago (2017-03-10 23:41:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2743653005/1
3 years, 9 months ago (2017-03-11 00:17:12 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-03-11 00:20:08 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/46d2457debb617b5ff4dfdbe6...

Powered by Google App Engine
This is Rietveld 408576698