Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2743063003: Include the header <cmath> (Closed)

Created:
3 years, 9 months ago by Zhi Huang
Modified:
3 years, 9 months ago
Reviewers:
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, audio-team_agora.io, sdk-team_agora.io, peah-webrtc, henrika_webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Include the header <cmath> The build breaks because there is no implementation of std::abs(double). BUG=None TBR=tkchin@webrtc.org Review-Url: https://codereview.webrtc.org/2743063003 Cr-Commit-Position: refs/heads/master@{#17176} Committed: https://chromium.googlesource.com/external/webrtc/+/9a1604b0273924f1d86b4499c00db65a09d4afce

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M webrtc/modules/audio_device/ios/audio_device_ios.mm View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (9 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2743063003/1
3 years, 9 months ago (2017-03-10 21:27:29 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 21:30:09 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/9a1604b0273924f1d86b4499c...

Powered by Google App Engine
This is Rietveld 408576698