Chromium Code Reviews

Issue 2742893002: Return correct type from OpenSSLStreamAdapter::VerifyPeerCertificate. (Closed)

Created:
3 years, 9 months ago by joachim
Modified:
3 years, 9 months ago
Reviewers:
Taylor Brandstetter
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Return correct type from OpenSSLStreamAdapter::VerifyPeerCertificate. The function signature expects to return a "bool" but in one code path it returned "0". BUG=None Review-Url: https://codereview.webrtc.org/2742893002 Cr-Commit-Position: refs/heads/master@{#17156} Committed: https://chromium.googlesource.com/external/webrtc/+/f8f457bd3f5bfc4907cd593a05ae7d72b9863d5c

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+1 line, -1 line)
M webrtc/base/opensslstreamadapter.cc View 1 chunk +1 line, -1 line 0 comments

Messages

Total messages: 9 (5 generated)
joachim
Ptal
3 years, 9 months ago (2017-03-09 23:57:16 UTC) #2
Taylor Brandstetter
lgtm
3 years, 9 months ago (2017-03-10 00:04:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2742893002/1
3 years, 9 months ago (2017-03-10 00:05:41 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 00:25:02 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/f8f457bd3f5bfc4907cd593a0...

Powered by Google App Engine