Reland of PyLint fixes for tools-webrtc and webrtc/tools

PRESUBMIT.py

Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 994fcf4c75b66787b46f2b09bf2fb15e44a2f936..7e7daf2e1d108c4619e72231c68901fc73e9650c 100755
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -126,7 +126,7 @@ def _VerifyNativeApiHeadersListIsValid(input_api, output_api):
         non_existing_paths)]
   return []
 
-api_change_msg = """
+API_CHANGE_MSG = """
 You seem to be changing native API header files. Please make sure that you:
   1. Make compatible changes that don't break existing clients. Usually
      this is done by keeping the existing method signatures unchanged.
@@ -155,7 +155,7 @@ def _CheckNativeApiHeaderChanges(input_api, output_api):
           files.append(f)
 
   if files:
-    return [output_api.PresubmitNotifyResult(api_change_msg, files)]
+    return [output_api.PresubmitNotifyResult(API_CHANGE_MSG, files)]
   return []
 
 
@@ -200,7 +200,7 @@ def _CheckNoPragmaOnce(input_api, output_api):
   return []
 
 
-def _CheckNoFRIEND_TEST(input_api, output_api):
+def _CheckNoFRIEND_TEST(input_api, output_api):  # pylint: disable=invalid-name
   """Make sure that gtest's FRIEND_TEST() macro is not used, the
   FRIEND_TEST_ALL_PREFIXES() macro from testsupport/gtest_prod_util.h should be
   used instead since that allows for FLAKY_, FAILS_ and DISABLED_ prefixes."""
@@ -466,13 +466,13 @@ def _CheckJSONParseErrors(input_api, output_api):
 
 
 def _RunPythonTests(input_api, output_api):
-  def join(*args):
+  def Join(*args):
     return input_api.os_path.join(input_api.PresubmitLocalPath(), *args)
 
   test_directories = [
-      join('webrtc', 'tools', 'py_event_log_analyzer')
+      Join('webrtc', 'tools', 'py_event_log_analyzer')
   ] + [
-      root for root, _, files in os.walk(join('tools-webrtc'))
+      root for root, _, files in os.walk(Join('tools-webrtc'))
       if any(f.endswith('_test.py') for f in files)
   ]