Make AudioBuffer::InterleaveTo const

Make AudioBuffer::InterleaveTo const

The only non-const operation was a one-time initialization of a member only used in this function. I've moved it to the ctor.

BUG=webrtc:5298
Review-Url: https://codereview.webrtc.org/2741733002
Cr-Commit-Position: refs/heads/master@{#17223}
Committed: https://chromium.googlesource.com/external/webrtc/+/c7daea8d6a13e29a797b641ffda0d87e601e8a61

[kthelgason, 2017-03-09 13:08:25]

The CQ bit was checked by kthelgason@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 13:08:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-09 13:29:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 13:29:06]

Dry run: This issue passed the CQ dry run.

[kthelgason, 2017-03-10 08:02:05]

Patchset #1 (id:1) has been deleted

[kthelgason, 2017-03-10 08:03:48]

Description was changed from

==========
WIP

Remove seemingly unneeded InterleaveTo calls
Make InterleaveTo const

BUG=None
==========

to

==========
Make AudioBuffer::InterleaveTo const

The only non-const operation was a one-time initialization of a member only used
in this function. I've moved it to the ctor.

BUG=None
==========

[kthelgason, 2017-03-10 08:03:48]

kthelgason@webrtc.org changed reviewers:
+ peah@webrtc.org

[kthelgason, 2017-03-10 08:03:57]

The CQ bit was checked by kthelgason@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 08:04:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[kthelgason, 2017-03-10 08:04:45]

peah@, please take a look.

In reference to our in-person discussion yesterday I decided I could at least
land this tiny change. Let me know what you think!

[commit-bot: I haz the power, 2017-03-10 08:23:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 08:23:39]

Dry run: This issue passed the CQ dry run.

[peah-webrtc, 2017-03-14 07:59:20]

Awesome change! Thanks!

I think you need to add a bug number though. If you want you can use
https://bugs.chromium.org/p/webrtc/issues/detail?id=5298, but please feel free
to add another issue for this.

LGTM

[kthelgason, 2017-03-14 09:18:33]

Description was changed from

==========
Make AudioBuffer::InterleaveTo const

The only non-const operation was a one-time initialization of a member only used
in this function. I've moved it to the ctor.

BUG=None
==========

to

==========
Make AudioBuffer::InterleaveTo const

The only non-const operation was a one-time initialization of a member only used
in this function. I've moved it to the ctor.

BUG=webrtc:5298
==========

[kthelgason, 2017-03-14 09:19:06]

On 2017/03/14 07:59:20, peah-webrtc wrote:
> Awesome change! Thanks!
> 
> I think you need to add a bug number though. If you want you can use
> https://bugs.chromium.org/p/webrtc/issues/detail?id=5298, but please feel free
> to add another issue for this.
> 
> LGTM

Thanks, I added this CL to the bug you linked, I don't think it deserves a
separate bug!

[kthelgason, 2017-03-14 09:19:09]

The CQ bit was checked by kthelgason@webrtc.org

[commit-bot: I haz the power, 2017-03-14 09:19:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-14 10:10:08]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489483149706270,
"parent_rev": "cfd88bbe80c41a4ec3d1eb529f60e06e8bad3de8", "commit_rev":
"c7daea8d6a13e29a797b641ffda0d87e601e8a61"}

[commit-bot: I haz the power, 2017-03-14 10:10:12]

Description was changed from

==========
Make AudioBuffer::InterleaveTo const

The only non-const operation was a one-time initialization of a member only used
in this function. I've moved it to the ctor.

BUG=webrtc:5298
==========

to

==========
Make AudioBuffer::InterleaveTo const

The only non-const operation was a one-time initialization of a member only used
in this function. I've moved it to the ctor.

BUG=webrtc:5298

Review-Url: https://codereview.webrtc.org/2741733002
Cr-Commit-Position: refs/heads/master@{#17223}
Committed:
https://chromium.googlesource.com/external/webrtc/+/c7daea8d6a13e29a797b641ff...
==========

[commit-bot: I haz the power, 2017-03-14 10:10:13]

Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/c7daea8d6a13e29a797b641ff...