Add flag to clean up temporary results after building iOS Framework or static lib

Add flag to clean up temporary results after building iOS Framework or static lib

The --purify flag can now be passed to remove the temporary
files and directories created while building the iOS Framework or static
library. That way, only the final result(s) are taking up space in the
output folder. 

BUG=None
NOTRY=True

Review-Url: https://codereview.webrtc.org/2740923003
Cr-Commit-Position: refs/heads/master@{#17224}
Committed: https://chromium.googlesource.com/external/webrtc/+/7b188e8fbb01f72f00f4526b2c72d52ba5b6aa23

[VladimirTechMan, 2017-03-10 06:02:39]

vladimirtechman@gmail.com changed reviewers:
+ kjellander@webrtc.org, kthelgason@webrtc.org

[kthelgason, 2017-03-10 08:06:13]

I see no reason not to land this, lgtm! And thanks again :)

kjellander@, WDYT?

[kthelgason, 2017-03-10 08:06:14]

I see no reason not to land this, lgtm! And thanks again :)

kjellander@, WDYT?

[kthelgason, 2017-03-10 08:09:22]

On the other hand, this means that a complete rebuild is necessary each time, if
a small change is made after the libs are built. 
I think this is quite common and would cause frustration at least internally.
not lgtm.

I think an alternative solution would be to put this behind a `clean` action it
the script.

[VladimirTechMan, 2017-03-10 19:52:21]

On 2017/03/10 08:09:22, kthelgason wrote:
> On the other hand, this means that a complete rebuild is necessary each time,
if
> a small change is made after the libs are built. 
> I think this is quite common and would cause frustration at least internally.
> not lgtm.
> 
> I think an alternative solution would be to put this behind a `clean` action
it
> the script.

Thanks, Kári. You are right. Overlooking that workflow would not be good, at
all.

Let's change it into a separate command line option. See the second patch set.

[kthelgason, 2017-03-13 10:07:41]

On 2017/03/10 19:52:21, VladimirTechMan wrote:
> On 2017/03/10 08:09:22, kthelgason wrote:
> > On the other hand, this means that a complete rebuild is necessary each
time,
> if
> > a small change is made after the libs are built. 
> > I think this is quite common and would cause frustration at least
internally.
> > not lgtm.
> > 
> > I think an alternative solution would be to put this behind a `clean` action
> it
> > the script.
> 
> Thanks, Kári. You are right. Overlooking that workflow would not be good, at
> all.
> 
> Let's change it into a separate command line option. See the second patch set.

This lgtm, thanks for your contributions :)

Kjellander@, your thoughts?

[kjellander_webrtc, 2017-03-13 13:15:02]

https://codereview.webrtc.org/2740923003/diff/20001/tools-webrtc/ios/build_io...
File tools-webrtc/ios/build_ios_libs.py (right):

https://codereview.webrtc.org/2740923003/diff/20001/tools-webrtc/ios/build_io...
tools-webrtc/ios/build_ios_libs.py:54: help='Removes the temporary build files
from the output directory.')
It's not clear to me that the script will exit after doing this. Either make it
clear here or just skip return 0 at line 163.

https://codereview.webrtc.org/2740923003/diff/20001/tools-webrtc/ios/build_io...
tools-webrtc/ios/build_ios_libs.py:238: 
nit: Remove this blank line.

[VladimirTechMan, 2017-03-13 23:40:31]

On 2017/03/13 13:15:02, kjellander_webrtc wrote:
>
https://codereview.webrtc.org/2740923003/diff/20001/tools-webrtc/ios/build_io...
> File tools-webrtc/ios/build_ios_libs.py (right):
> 
>
https://codereview.webrtc.org/2740923003/diff/20001/tools-webrtc/ios/build_io...
> tools-webrtc/ios/build_ios_libs.py:54: help='Removes the temporary build files
> from the output directory.')
> It's not clear to me that the script will exit after doing this. Either make
it
> clear here or just skip return 0 at line 163.
> 
>
https://codereview.webrtc.org/2740923003/diff/20001/tools-webrtc/ios/build_io...
> tools-webrtc/ios/build_ios_libs.py:238: 
> nit: Remove this blank line.

Thanks, Henrik. Let me know if the updated wording is better.

[kjellander_webrtc, 2017-03-14 07:13:50]

Description was changed from

==========
Clean up temporary results after building iOS Framework or static lib

Updating the builder script logic to automatically remove the temporary
files and directories created while building the iOS Framework or static
library. That way, only the final result(s) are taking up space in the
output folder. Let me know if it lgty.

BUG=None
==========

to

==========
Clean up temporary results after building iOS Framework or static lib

Updating the builder script logic to automatically remove the temporary
files and directories created while building the iOS Framework or static
library. That way, only the final result(s) are taking up space in the
output folder. Let me know if it lgty.

BUG=None
NOTRY=True
==========

[kjellander_webrtc, 2017-03-14 07:14:52]

Description was changed from

==========
Clean up temporary results after building iOS Framework or static lib

Updating the builder script logic to automatically remove the temporary
files and directories created while building the iOS Framework or static
library. That way, only the final result(s) are taking up space in the
output folder. Let me know if it lgty.

BUG=None
NOTRY=True
==========

to

==========
Add flag to clean up temporary results after building iOS Framework or static
lib

The --purify flag can now be passed to remove the temporary
files and directories created while building the iOS Framework or static
library. That way, only the final result(s) are taking up space in the
output folder. 

BUG=None
NOTRY=True
==========

[kjellander_webrtc, 2017-03-14 07:16:07]

I updated the CL description to better match what was changed now. 
I'm fine with this flag so this lgtm

Please wait for ios_api_framework trybot to go green before you submit this.

[kthelgason, 2017-03-14 10:09:57]

The CQ bit was checked by kthelgason@webrtc.org

[kthelgason, 2017-03-14 10:09:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
kthelgason@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2740923003/#ps40001 (title:
"Clean up temporary results after building iOS Framework or static lib")

[commit-bot: I haz the power, 2017-03-14 10:10:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-14 10:12:36]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489486197987630,
"parent_rev": "c7daea8d6a13e29a797b641ffda0d87e601e8a61", "commit_rev":
"7b188e8fbb01f72f00f4526b2c72d52ba5b6aa23"}

[commit-bot: I haz the power, 2017-03-14 10:12:38]

Description was changed from

==========
Add flag to clean up temporary results after building iOS Framework or static
lib

The --purify flag can now be passed to remove the temporary
files and directories created while building the iOS Framework or static
library. That way, only the final result(s) are taking up space in the
output folder. 

BUG=None
NOTRY=True
==========

to

==========
Add flag to clean up temporary results after building iOS Framework or static
lib

The --purify flag can now be passed to remove the temporary
files and directories created while building the iOS Framework or static
library. That way, only the final result(s) are taking up space in the
output folder. 

BUG=None
NOTRY=True

Review-Url: https://codereview.webrtc.org/2740923003
Cr-Commit-Position: refs/heads/master@{#17224}
Committed:
https://chromium.googlesource.com/external/webrtc/+/7b188e8fbb01f72f00f4526b2...
==========

[commit-bot: I haz the power, 2017-03-14 10:12:42]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/7b188e8fbb01f72f00f4526b2...