Index: webrtc/modules/audio_processing/test/conversational_speech/settings.h |
diff --git a/webrtc/modules/audio_processing/test/conversational_speech/settings.h b/webrtc/modules/audio_processing/test/conversational_speech/settings.h |
new file mode 100644 |
index 0000000000000000000000000000000000000000..dcbf8f248114b00c51476d71d86698a30d80cade |
--- /dev/null |
+++ b/webrtc/modules/audio_processing/test/conversational_speech/settings.h |
@@ -0,0 +1,55 @@ |
+/* |
+ * Copyright (c) 2017 The WebRTC project authors. All Rights Reserved. |
+ * |
+ * Use of this source code is governed by a BSD-style license |
+ * that can be found in the LICENSE file in the root of the source |
+ * tree. An additional intellectual property rights grant can be found |
+ * in the file PATENTS. All contributing project authors may |
+ * be found in the AUTHORS file in the root of the source tree. |
+ */ |
+ |
+#ifndef WEBRTC_MODULES_AUDIO_PROCESSING_TEST_CONVERSATIONAL_SPEECH_SETTINGS_H_ |
+#define WEBRTC_MODULES_AUDIO_PROCESSING_TEST_CONVERSATIONAL_SPEECH_SETTINGS_H_ |
+ |
+#include <ostream> |
+#include <string> |
+ |
+namespace webrtc { |
+namespace test { |
+namespace convspeechgen { |
hlundin-webrtc
2017/03/13 12:28:19
I think you can drop this namespace, and maybe giv
AleBzk
2017/03/13 14:14:41
Done.
|
+ |
+class Settings { |
hlundin-webrtc
2017/03/13 12:28:19
If all of the error handling can be done by gflags
AleBzk
2017/03/13 14:14:41
Done.
|
+ public: |
+ Settings(std::string audiotracks_path, std::string timing_filepath, |
hlundin-webrtc
2017/03/13 12:28:19
Make the input parameters const references instead
AleBzk
2017/03/13 14:14:41
Done.
|
+ std::string output_path) |
+ : audiotracks_path_(audiotracks_path), timing_filepath_( |
+ timing_filepath), output_path_(output_path) {} |
+ |
+ // Getters. |
hlundin-webrtc
2017/03/13 12:28:19
Superfluous comment.
AleBzk
2017/03/13 14:14:41
Done.
|
+ const std::string AudiotracksPath(void); |
hlundin-webrtc
2017/03/13 12:28:19
const std::string makes little sense. Either drop
hlundin-webrtc
2017/03/13 12:28:19
Don't add the void parameter.
AleBzk
2017/03/13 14:14:41
Acknowledged.
AleBzk
2017/03/13 14:14:41
Acknowledged.
|
+ const std::string TimingFilePath(void); |
+ const std::string OutputPath(void); |
+ |
+ // Checks all the settings and report all the errors that are found. |
+ bool ValidateAndReport(void); |
hlundin-webrtc
2017/03/13 12:28:19
Drop void.
hlundin-webrtc
2017/03/13 12:28:19
const method?
AleBzk
2017/03/13 14:14:41
Acknowledged.
|
+ |
+ private: |
+ std::string audiotracks_path_; |
hlundin-webrtc
2017/03/13 12:28:19
Declare methods before member variables.
https://g
hlundin-webrtc
2017/03/13 12:28:19
You can make these variables const.
const std::str
AleBzk
2017/03/13 14:14:41
Done.
|
+ std::string timing_filepath_; |
+ std::string output_path_; |
+ |
+ // Checks if a path to a file exists. |
+ static bool ValidateFilePath(std::string* path); |
hlundin-webrtc
2017/03/13 12:28:19
You can use FileExists in webrtc/test/testsupport/
AleBzk
2017/03/13 14:14:42
Done.
|
+ |
+ // Checks if a path to a directory exists. |
+ static bool ValidateDirectoryPath(std::string* path); |
hlundin-webrtc
2017/03/13 12:28:19
Consider extending webrtc/test/testsupport/fileuti
AleBzk
2017/03/13 14:14:41
Done.
|
+ |
+ // If condition is true, prints a message into the standard error. |
+ void ReportConditionalError(bool condition, std::string message); |
+}; |
+ |
+} // namespace convspeechgen |
+} // namespace test |
+} // namespace webrtc |
+ |
+#endif // WEBRTC_MODULES_AUDIO_PROCESSING_TEST_CONVERSATIONAL_SPEECH_SETTINGS_H_ |