Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
3 years, 9 months ago by ilnik Modified:
3 years, 9 months ago Reviewers:
nisse-webrtc, Taylor Brandstetter CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionFix CpuTimeTest to tolerate MSAN interference (some background test-related work).
BUG=none
Review-Url: https://codereview.webrtc.org/2739673003
Cr-Commit-Position: refs/heads/master@{#17132}
Committed: https://chromium.googlesource.com/external/webrtc/+/3e530d20cad074d2220b66cbe858d8d255811dfb
Patch Set 1 #
Created: 3 years, 9 months ago
Messages
Total messages: 19 (9 generated)
ilnik@webrtc.org changed reviewers: + deadbeef@webrtc.org
nisse@webrtc.org changed reviewers: + nisse@webrtc.org
LGTM. Hope it's enough to eliminate flakyness. In the description, I think it should be "BUG=none", with no "webrtc:" prefix.
Description was changed from ========== Fix CpuTimeTest to tolerate background test related threads BUG=webrtc:none ========== to ========== Fix CpuTimeTest to tolerate background test related threads BUG=none ==========
The CQ bit was checked by ilnik@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/14606)
On 2017/03/08 09:52:59, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > presubmit on master.tryserver.webrtc (JOB_FAILED, > http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/14606) Taylor, please take a look then you have time. It's a low priority --- fixing a little flaky base unittest.
lgtm. Out of curiosity though, what are the background test-related threads?
On 2017/03/08 19:04:48, Taylor Brandstetter wrote: > lgtm. Out of curiosity though, what are the background test-related threads? Not sure (I didn't formulate this comment), but the test failed on an msan bot, which I imagine does a lot of extra work.
On 2017/03/09 07:51:17, nisse-webrtc (ooo March 6) wrote: > On 2017/03/08 19:04:48, Taylor Brandstetter wrote: > > lgtm. Out of curiosity though, what are the background test-related threads? > > Not sure (I didn't formulate this comment), but the test failed on an msan bot, > which I imagine does a lot of extra work. Yes, from the output of the failed test it's clear that process time is much more that the threads I created. Therefore something to do with MSAN does background work inside the process. I will reformulate the comment to be more descriptive.
Description was changed from ========== Fix CpuTimeTest to tolerate background test related threads BUG=none ========== to ========== Fix CpuTimeTest to tolerate MSAN interference (some background test-related work). BUG=none ==========
The CQ bit was checked by ilnik@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1489048755834310, "parent_rev":
"b05d9b292a17f7f480555454a4cf888b32288172", "commit_rev":
"3e530d20cad074d2220b66cbe858d8d255811dfb"}
Message was sent while issue was closed.
Description was changed from ========== Fix CpuTimeTest to tolerate MSAN interference (some background test-related work). BUG=none ========== to ========== Fix CpuTimeTest to tolerate MSAN interference (some background test-related work). BUG=none Review-Url: https://codereview.webrtc.org/2739673003 Cr-Commit-Position: refs/heads/master@{#17132} Committed: https://chromium.googlesource.com/external/webrtc/+/3e530d20cad074d2220b66cbe... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/3e530d20cad074d2220b66cbe... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
