Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2739613003: Disable failing fullstack test with 15 thumbnail streams (Closed)

Created:
3 years, 9 months ago by ilnik
Modified:
3 years, 9 months ago
Reviewers:
sprang_webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Disable failing fullstack test with 15 thumbnail streams BUG=webrtc:7301 Review-Url: https://codereview.webrtc.org/2739613003 Cr-Commit-Position: refs/heads/master@{#17095} Committed: https://chromium.googlesource.com/external/webrtc/+/f89a738626b572eb4ec06218d3bc545d8b11fb59

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M webrtc/video/full_stack_tests.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M webrtc/video/video_quality_test.cc View 1 chunk +1 line, -0 lines 1 comment Download

Messages

Total messages: 9 (4 generated)
ilnik
3 years, 9 months ago (2017-03-07 13:44:55 UTC) #2
sprang_webrtc
lgtm
3 years, 9 months ago (2017-03-07 13:48:46 UTC) #3
sprang_webrtc
https://codereview.webrtc.org/2739613003/diff/1/webrtc/video/video_quality_test.cc File webrtc/video/video_quality_test.cc (right): https://codereview.webrtc.org/2739613003/diff/1/webrtc/video/video_quality_test.cc#newcode1518 webrtc/video/video_quality_test.cc:1518: RTC_DCHECK(thumbnail_capturers_.back()); Any idea why this would fail? Out of ...
3 years, 9 months ago (2017-03-07 13:49:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2739613003/1
3 years, 9 months ago (2017-03-07 13:51:24 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 14:15:30 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/f89a738626b572eb4ec06218d...

Powered by Google App Engine
This is Rietveld 408576698