Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2739393002: Revert of Rewrite frame generator capturer to use TaskQueue instead of EventTimeWrapper (Closed)

Created:
3 years, 9 months ago by ilnik
Modified:
3 years, 9 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Rewrite frame generator capturer to use TaskQueue instead of EventTimeWrapper (patchset #4 id:60001 of https://codereview.webrtc.org/2740723002/ ) Reason for revert: Less precise FrameGeneratorCapturer broke CallPerfTest.ReceivesCpuOveruseAndUnderuse on Android Original issue's description: > Rewrite frame generator capturer to use TaskQueue instead of EventTimeWrapper > > BUG=webrtc:7301 > > Review-Url: https://codereview.webrtc.org/2740723002 > Cr-Commit-Position: refs/heads/master@{#17161} > Committed: https://chromium.googlesource.com/external/webrtc/+/7c5503a8b30ae43a8ccaa18518e3114c1b8babe3 TBR=kjellander@webrtc.org,sprang@webrtc.org,tommi@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7301 Review-Url: https://codereview.webrtc.org/2739393002 Cr-Commit-Position: refs/heads/master@{#17163} Committed: https://chromium.googlesource.com/external/webrtc/+/c37d2b96b812b4ec2c81d7bce1bb57be13ecaacf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -47 lines) Patch
M webrtc/test/frame_generator_capturer.h View 4 chunks +5 lines, -6 lines 0 comments Download
M webrtc/test/frame_generator_capturer.cc View 6 chunks +17 lines, -41 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
ilnik
Created Revert of Rewrite frame generator capturer to use TaskQueue instead of EventTimeWrapper
3 years, 9 months ago (2017-03-10 12:04:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2739393002/1
3 years, 9 months ago (2017-03-10 12:04:34 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/c37d2b96b812b4ec2c81d7bce1bb57be13ecaacf
3 years, 9 months ago (2017-03-10 12:04:42 UTC) #6
ilnik
3 years, 9 months ago (2017-03-10 12:06:35 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2745583006/ by ilnik@webrtc.org.

The reason for reverting is: Reland reverted patch to add fixes for failing
tests.

Powered by Google App Engine
This is Rietveld 408576698