Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Issue 2738513005: Fix error handling in X11 screen capturer (Closed)

Created:
3 years, 9 months ago by Sergey Ulanov
Modified:
3 years, 9 months ago
Reviewers:
Hzj_jie
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix error handling in X11 screen capturer Previusly errors from XServerPixelBuffer::CaptureRect() were not always handled, which results in a black frame returned from the capturer instead of an error. BUG=webrtc:7305 Review-Url: https://codereview.webrtc.org/2738513005 Cr-Commit-Position: refs/heads/master@{#17101} Committed: https://chromium.googlesource.com/external/webrtc/+/9fa7e4a0ac20b89f6c147f27a7e04a762378aaa4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M webrtc/modules/desktop_capture/screen_capturer_x11.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
Sergey Ulanov
3 years, 9 months ago (2017-03-06 22:39:52 UTC) #2
Hzj_jie
On 2017/03/06 22:39:52, Sergey Ulanov wrote: lgtm.
3 years, 9 months ago (2017-03-07 20:36:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2738513005/1
3 years, 9 months ago (2017-03-08 00:32:25 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/14593)
3 years, 9 months ago (2017-03-08 00:36:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2738513005/1
3 years, 9 months ago (2017-03-08 00:49:46 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 01:02:25 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/9fa7e4a0ac20b89f6c147f27a...

Powered by Google App Engine
This is Rietveld 408576698