Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1116)

Unified Diff: tools-webrtc/get_landmines.py

Issue 2737233003: Revert of PyLint fixes for tools-webrtc and webrtc/tools (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools-webrtc/check_package_boundaries_test.py ('k') | tools-webrtc/gn_check_autofix.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools-webrtc/get_landmines.py
diff --git a/tools-webrtc/get_landmines.py b/tools-webrtc/get_landmines.py
index 95ee5361ba9de6d7c4094173b354d7b6f31aa2f5..dd0c9b05ec0025743c066cfa2e25cced62f85f77 100755
--- a/tools-webrtc/get_landmines.py
+++ b/tools-webrtc/get_landmines.py
@@ -15,16 +15,19 @@
import os
import sys
-SCRIPT_DIR = os.path.dirname(os.path.realpath(__file__))
-CHECKOUT_ROOT = os.path.abspath(os.path.join(SCRIPT_DIR, os.pardir))
-sys.path.insert(0, os.path.join(CHECKOUT_ROOT, 'build'))
+script_dir = os.path.dirname(os.path.realpath(__file__))
+checkout_root = os.path.abspath(os.path.join(script_dir, os.pardir))
+sys.path.insert(0, os.path.join(checkout_root, 'build'))
import landmine_utils
-platform = landmine_utils.platform # pylint: disable=invalid-name
+distributor = landmine_utils.distributor
+gyp_defines = landmine_utils.gyp_defines
+gyp_msvs_version = landmine_utils.gyp_msvs_version
+platform = landmine_utils.platform
-def print_landmines(): # pylint: disable=invalid-name
+def print_landmines():
"""
ALL LANDMINES ARE EMITTED FROM HERE.
"""
@@ -51,7 +54,7 @@
# is no longer the case.
print 'Clobber due to iOS compile errors (crbug.com/694721)'
print 'Clobber to unblock https://codereview.webrtc.org/2709573003'
- print 'Clobber to fix after https://codereview.webrtc.org/2709573003'
+ print 'Clobber to fix https://codereview.webrtc.org/2709573003 after landing'
def main():
« no previous file with comments | « tools-webrtc/check_package_boundaries_test.py ('k') | tools-webrtc/gn_check_autofix.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698