Android HW decoder: Don't check slice_height for texture output

Android HW decoder: Don't check slice_height for texture output

The check: 'RTC_CHECK_GE(slice_height, height);' has been observed to
fail after a reconfig. It looks like |slice_height| is still using the
previous resolution. |slice_height| isn't used for texture output and
hopefully this issue is texture specific. This CL only extracts and
checks |slice_height| when it's actually used.

BUG=b/35932686

Review-Url: https://codereview.webrtc.org/2736603003
Cr-Commit-Position: refs/heads/master@{#17065}
Committed: https://chromium.googlesource.com/external/webrtc/+/d1587ad244af3388c1282a715cdf05032ba0c2fc

[magjed_webrtc, 2017-03-06 12:08:53]

The CQ bit was checked by magjed@webrtc.org to run a CQ dry run

[magjed_webrtc, 2017-03-06 12:09:07]

Description was changed from

==========
Android HW decoder: Don't check slice_height for texture output

The check: 'RTC_CHECK_GE(slice_height, height);' has been observed to
fail after a reconfig. It looks like |slice_height| is still using the
previous resolution. |slice_height| isn't used for texture output and
hopefully this issue is texture specific. This CL only extracts and
checks |slice_height| when it's actually used.

BUG=b/35932686
==========

to

==========
Android HW decoder: Don't check slice_height for texture output

The check: 'RTC_CHECK_GE(slice_height, height);' has been observed to
fail after a reconfig. It looks like |slice_height| is still using the
previous resolution. |slice_height| isn't used for texture output and
hopefully this issue is texture specific. This CL only extracts and
checks |slice_height| when it's actually used.

BUG=b/35932686
==========

[magjed_webrtc, 2017-03-06 12:09:07]

magjed@webrtc.org changed reviewers:
+ sakal@webrtc.org

[magjed_webrtc, 2017-03-06 12:09:18]

Sami - please take a look.

[sakal, 2017-03-06 12:36:41]

lgtm

https://codereview.webrtc.org/2736603003/diff/1/webrtc/sdk/android/src/jni/an...
File webrtc/sdk/android/src/jni/androidmediadecoder_jni.cc (left):

https://codereview.webrtc.org/2736603003/diff/1/webrtc/sdk/android/src/jni/an...
webrtc/sdk/android/src/jni/androidmediadecoder_jni.cc:873: ". " << stride << " x
" <<  slice_height <<
nit: Maybe add this log line back inside the else block.

[magjed_webrtc, 2017-03-06 13:01:08]

The CQ bit was checked by magjed@webrtc.org

[commit-bot: I haz the power, 2017-03-06 13:01:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-06 13:20:50]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1488805268312800, "parent_rev":
"87ee970776bc19be7e2f29228dea88e236dc360b", "commit_rev":
"d1587ad244af3388c1282a715cdf05032ba0c2fc"}

[commit-bot: I haz the power, 2017-03-06 13:20:52]

Description was changed from

==========
Android HW decoder: Don't check slice_height for texture output

The check: 'RTC_CHECK_GE(slice_height, height);' has been observed to
fail after a reconfig. It looks like |slice_height| is still using the
previous resolution. |slice_height| isn't used for texture output and
hopefully this issue is texture specific. This CL only extracts and
checks |slice_height| when it's actually used.

BUG=b/35932686
==========

to

==========
Android HW decoder: Don't check slice_height for texture output

The check: 'RTC_CHECK_GE(slice_height, height);' has been observed to
fail after a reconfig. It looks like |slice_height| is still using the
previous resolution. |slice_height| isn't used for texture output and
hopefully this issue is texture specific. This CL only extracts and
checks |slice_height| when it's actually used.

BUG=b/35932686

Review-Url: https://codereview.webrtc.org/2736603003
Cr-Commit-Position: refs/heads/master@{#17065}
Committed:
https://chromium.googlesource.com/external/webrtc/+/d1587ad244af3388c1282a715...
==========

[commit-bot: I haz the power, 2017-03-06 13:20:53]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/d1587ad244af3388c1282a715...