Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: tools-webrtc/network_emulator/network_emulator.py

Issue 2736233003: PyLint fixes for tools-webrtc and webrtc/tools (Closed)
Patch Set: Fix alignment Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools-webrtc/network_emulator/network_emulator.py
diff --git a/tools-webrtc/network_emulator/network_emulator.py b/tools-webrtc/network_emulator/network_emulator.py
index 9bdf7bd95b8857ee2604a98e425765a9098fca22..aa3ebda4c0bcb021a72a811552782f7363b5d661 100644
--- a/tools-webrtc/network_emulator/network_emulator.py
+++ b/tools-webrtc/network_emulator/network_emulator.py
@@ -53,20 +53,20 @@ class NetworkEmulator(object):
self._port_range = port_range
self._connection_config = connection_config
- def emulate(self, target_ip):
+ def Emulate(self, target_ip):
"""Starts a network emulation by setting up Dummynet rules.
Args:
target_ip: The IP address of the interface that shall be that have the
network constraints applied to it.
"""
- receive_pipe_id = self._create_dummynet_pipe(
+ receive_pipe_id = self._CreateDummynetPipe(
self._connection_config.receive_bw_kbps,
self._connection_config.delay_ms,
self._connection_config.packet_loss_percent,
self._connection_config.queue_slots)
logging.debug('Created receive pipe: %s', receive_pipe_id)
- send_pipe_id = self._create_dummynet_pipe(
+ send_pipe_id = self._CreateDummynetPipe(
self._connection_config.send_bw_kbps,
self._connection_config.delay_ms,
self._connection_config.packet_loss_percent,
@@ -74,15 +74,15 @@ class NetworkEmulator(object):
logging.debug('Created send pipe: %s', send_pipe_id)
# Adding the rules will start the emulation.
- incoming_rule_id = self._create_dummynet_rule(receive_pipe_id, 'any',
- target_ip, self._port_range)
+ incoming_rule_id = self._CreateDummynetRule(receive_pipe_id, 'any',
+ target_ip, self._port_range)
logging.debug('Created incoming rule: %s', incoming_rule_id)
- outgoing_rule_id = self._create_dummynet_rule(send_pipe_id, target_ip,
- 'any', self._port_range)
+ outgoing_rule_id = self._CreateDummynetRule(send_pipe_id, target_ip,
+ 'any', self._port_range)
logging.debug('Created outgoing rule: %s', outgoing_rule_id)
@staticmethod
- def check_permissions():
+ def CheckPermissions():
"""Checks if permissions are available to run Dummynet commands.
Raises:
@@ -99,8 +99,8 @@ class NetworkEmulator(object):
raise NetworkEmulatorError('You must run this script with administrator'
' privileges.')
- def _create_dummynet_rule(self, pipe_id, from_address, to_address,
- port_range):
+ def _CreateDummynetRule(self, pipe_id, from_address, to_address,
+ port_range):
"""Creates a network emulation rule and returns its ID.
Args:
@@ -118,14 +118,14 @@ class NetworkEmulator(object):
self._rule_counter += 100
add_part = ['add', self._rule_counter, 'pipe', pipe_id,
'ip', 'from', from_address, 'to', to_address]
- _run_ipfw_command(add_part + ['src-port', '%s-%s' % port_range],
+ _RunIpfwCommand(add_part + ['src-port', '%s-%s' % port_range],
'Failed to add Dummynet src-port rule.')
- _run_ipfw_command(add_part + ['dst-port', '%s-%s' % port_range],
+ _RunIpfwCommand(add_part + ['dst-port', '%s-%s' % port_range],
'Failed to add Dummynet dst-port rule.')
return self._rule_counter
- def _create_dummynet_pipe(self, bandwidth_kbps, delay_ms, packet_loss_percent,
- queue_slots):
+ def _CreateDummynetPipe(self, bandwidth_kbps, delay_ms, packet_loss_percent,
+ queue_slots):
"""Creates a Dummynet pipe and return its ID.
Args:
@@ -146,21 +146,21 @@ class NetworkEmulator(object):
if sys.platform.startswith('linux'):
error_message += ('Make sure you have loaded the ipfw_mod.ko module to '
'your kernel (sudo insmod /path/to/ipfw_mod.ko).')
- _run_ipfw_command(cmd, error_message)
+ _RunIpfwCommand(cmd, error_message)
return self._pipe_counter
-def cleanup():
+def Cleanup():
"""Stops the network emulation by flushing all Dummynet rules.
Notice that this will flush any rules that may have been created previously
before starting the emulation.
"""
- _run_ipfw_command(['-f', 'flush'],
+ _RunIpfwCommand(['-f', 'flush'],
'Failed to flush Dummynet rules!')
- _run_ipfw_command(['-f', 'pipe', 'flush'],
+ _RunIpfwCommand(['-f', 'pipe', 'flush'],
'Failed to flush Dummynet pipes!')
-def _run_ipfw_command(command, fail_msg=None):
+def _RunIpfwCommand(command, fail_msg=None):
"""Executes a command and prefixes the appropriate command for
Windows or Linux/UNIX.
« no previous file with comments | « tools-webrtc/network_emulator/emulate.py ('k') | webrtc/examples/androidtests/video_quality_loopback_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698