Make StunMessage::attrs_ a vector of unique_ptrs instead of a pointer to a vector of pointers.

Replace StunMessage's vector<StunAttribute*>* with a
vector<unique_ptr<StunAttribute>> as suggested in a TODO.

BUG=NONE

Review-Url: https://codereview.webrtc.org/2735523002
Cr-Commit-Position: refs/heads/master@{#17076}
Committed: https://chromium.googlesource.com/external/webrtc/+/ad94c4c5d9e3e3766a80e32551c877878049e1d3

[zstein2, 2017-03-04 04:12:19]

The CQ bit was checked by zstein@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-04 04:12:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-04 04:16:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-04 04:16:58]

Dry run: Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/14479)

[Zach Stein, 2017-03-04 06:53:02]

Description was changed from

==========
Replace a vector<StunAttribute*>* with a vector<unique_ptr<StunAttribute>>

BUG=
==========

to

==========
Replace a vector<StunAttribute*>* with a vector<unique_ptr<StunAttribute>> as
suggested in a TODO.
==========

[Zach Stein, 2017-03-04 06:53:03]

zstein@webrtc.org changed reviewers:
+ deadbeef@webrtc.org, honghaiz@webrtc.org
- zstein@google.com

[Taylor Brandstetter, 2017-03-06 18:25:40]

lgtm

https://codereview.webrtc.org/2735523002/diff/1/webrtc/p2p/base/stun.cc
File webrtc/p2p/base/stun.cc (right):

https://codereview.webrtc.org/2735523002/diff/1/webrtc/p2p/base/stun.cc#newco...
webrtc/p2p/base/stun.cc:69: void StunMessage::AddAttribute(StunAttribute* attr)
{
Could you also change AddAttribute to take a unique_ptr, or add a TODO for that
as well?

[Zach Stein, 2017-03-06 20:51:28]

Description was changed from

==========
Replace a vector<StunAttribute*>* with a vector<unique_ptr<StunAttribute>> as
suggested in a TODO.
==========

to

==========
Replace StunMessage's vector<StunAttribute*>* with a
vector<unique_ptr<StunAttribute>> as suggested in a TODO.
==========

[Zach Stein, 2017-03-06 20:52:48]

Description was changed from

==========
Replace StunMessage's vector<StunAttribute*>* with a
vector<unique_ptr<StunAttribute>> as suggested in a TODO.
==========

to

==========
Replace StunMessage's vector<StunAttribute*>* with a
vector<unique_ptr<StunAttribute>> as suggested in a TODO.
==========

[Zach Stein, 2017-03-06 20:53:06]

Description was changed from

==========
Replace StunMessage's vector<StunAttribute*>* with a
vector<unique_ptr<StunAttribute>> as suggested in a TODO.
==========

to

==========
Replace StunMessage's vector<StunAttribute*>* with a
vector<unique_ptr<StunAttribute>> as suggested in a TODO.

BUG=NONE
==========

[Zach Stein, 2017-03-06 20:53:28]

The CQ bit was checked by zstein@webrtc.org

[Zach Stein, 2017-03-06 20:53:29]

The patchset sent to the CQ was uploaded after l-g-t-m from deadbeef@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2735523002/#ps20001 (title:
"Add a comment to update StunMessage::AddAttribute to take a unique_ptr.")

[commit-bot: I haz the power, 2017-03-06 20:53:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-06 21:36:06]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488833608926750,
"parent_rev": "d5a2d9ad0cbfa38f58582c19920c24733059d2a2", "commit_rev":
"ad94c4c5d9e3e3766a80e32551c877878049e1d3"}

[commit-bot: I haz the power, 2017-03-06 21:36:10]

Description was changed from

==========
Replace StunMessage's vector<StunAttribute*>* with a
vector<unique_ptr<StunAttribute>> as suggested in a TODO.

BUG=NONE
==========

to

==========
Replace StunMessage's vector<StunAttribute*>* with a
vector<unique_ptr<StunAttribute>> as suggested in a TODO.

BUG=NONE

Review-Url: https://codereview.webrtc.org/2735523002
Cr-Commit-Position: refs/heads/master@{#17076}
Committed:
https://chromium.googlesource.com/external/webrtc/+/ad94c4c5d9e3e3766a80e3255...
==========

[commit-bot: I haz the power, 2017-03-06 21:36:11]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/ad94c4c5d9e3e3766a80e3255...