Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(902)

Issue 2735423002: Mark |Clock*| as |const Clock*| (for some CongestionController and BWE related modules) (Closed)

Created:
3 years, 9 months ago by elad.alon
Modified:
3 years, 9 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Mark |Clock*| as |const Clock*| (for some CongestionController and BWE related modules) BUG=None Review-Url: https://codereview.webrtc.org/2735423002 Cr-Commit-Position: refs/heads/master@{#17148} Committed: https://chromium.googlesource.com/external/webrtc/+/61ce37e2e00e39d5c97e976cb820399ea5d4e86e

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -43 lines) Patch
M webrtc/base/rate_limiter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/base/rate_limiter.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/bitrate_controller/bitrate_controller_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/bitrate_controller/bitrate_controller_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/modules/bitrate_controller/include/bitrate_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/congestion_controller/congestion_controller.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/congestion_controller/delay_based_bwe.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/congestion_controller/delay_based_bwe.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/congestion_controller/include/congestion_controller.h View 1 4 chunks +6 lines, -5 lines 0 comments Download
M webrtc/modules/congestion_controller/probe_controller.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/congestion_controller/probe_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/congestion_controller/transport_feedback_adapter.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/congestion_controller/transport_feedback_adapter.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/pacing/paced_sender.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/pacing/paced_sender.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/include/send_time_history.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/send_time_history.cc View 1 chunk +2 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (7 generated)
elad.alon_webrtc.org
Ready for your review, Minyue. Let me know when and I'll add other reviewers.
3 years, 9 months ago (2017-03-08 19:04:35 UTC) #3
stefan-webrtc
lgtm
3 years, 9 months ago (2017-03-09 14:18:39 UTC) #5
elad.alon_webrtc.org
Adding Stefan, as I'm already asking him for his opinion and/or lgtm.
3 years, 9 months ago (2017-03-09 14:19:05 UTC) #6
elad.alon_webrtc.org
On 2017/03/09 14:19:05, elad.alon wrote: > Adding Stefan, as I'm already asking him for his ...
3 years, 9 months ago (2017-03-09 14:20:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2735423002/20001
3 years, 9 months ago (2017-03-09 14:46:41 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 15:09:35 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/61ce37e2e00e39d5c97e976cb...

Powered by Google App Engine
This is Rietveld 408576698