Update licence generation script after GYP->GN migration.

Update licence generation script after GYP->GN migration.

BUG=webrtc:6372
Review-Url: https://codereview.webrtc.org/2735173002
Cr-Commit-Position: refs/heads/master@{#17212}
Committed: https://chromium.googlesource.com/external/webrtc/+/96feb2ac1c2f0b3a477807db7a11d10eb5a138bd

[kthelgason, 2017-03-08 13:24:51]

kthelgason@webrtc.org changed reviewers:
+ kjellander@webrtc.org, magjed@webrtc.org

[kjellander_webrtc, 2017-03-08 14:00:39]

Nice to get this finally going. lgtm with comments addressed.

https://codereview.webrtc.org/2735173002/diff/130001/tools-webrtc/ios/build_i...
File tools-webrtc/ios/build_ios_libs.py (right):

https://codereview.webrtc.org/2735173002/diff/130001/tools-webrtc/ios/build_i...
tools-webrtc/ios/build_ios_libs.py:209:
os.path.dirname(os.path.realpath(__file__)),
join with SCRIPT_DIR instead.

https://codereview.webrtc.org/2735173002/diff/130001/tools-webrtc/ios/build_i...
tools-webrtc/ios/build_ios_libs.py:213: cmd = ['python', license_script_path,
gn_target_full_name, ninja_dir,
use sys.executable instead of 'python'

[magjed_webrtc, 2017-03-09 13:23:34]

lgtm

https://codereview.webrtc.org/2735173002/diff/130001/tools-webrtc/ios/generat...
File tools-webrtc/ios/generate_licenses.py (right):

https://codereview.webrtc.org/2735173002/diff/130001/tools-webrtc/ios/generat...
tools-webrtc/ios/generate_licenses.py:42: return re.sub(r'\(.*\)', '',
s).strip().split(os.path.sep)[-1].split(':')[0]
Can you add a comment giving an example input and output of this function?

[kthelgason, 2017-03-09 14:45:53]

kthelgason@webrtc.org changed reviewers:
+ tkchin@webrtc.org

[kthelgason, 2017-03-09 14:45:54]

Adding tkchin as well, as discussed.

https://codereview.webrtc.org/2735173002/diff/130001/tools-webrtc/ios/build_i...
File tools-webrtc/ios/build_ios_libs.py (right):

https://codereview.webrtc.org/2735173002/diff/130001/tools-webrtc/ios/build_i...
tools-webrtc/ios/build_ios_libs.py:209:
os.path.dirname(os.path.realpath(__file__)),
On 2017/03/08 14:00:39, kjellander_webrtc wrote:
> join with SCRIPT_DIR instead.

Done.

https://codereview.webrtc.org/2735173002/diff/130001/tools-webrtc/ios/build_i...
tools-webrtc/ios/build_ios_libs.py:213: cmd = ['python', license_script_path,
gn_target_full_name, ninja_dir,
On 2017/03/08 14:00:39, kjellander_webrtc wrote:
> use sys.executable instead of 'python'

Done.

https://codereview.webrtc.org/2735173002/diff/130001/tools-webrtc/ios/generat...
File tools-webrtc/ios/generate_licenses.py (right):

https://codereview.webrtc.org/2735173002/diff/130001/tools-webrtc/ios/generat...
tools-webrtc/ios/generate_licenses.py:42: return re.sub(r'\(.*\)', '',
s).strip().split(os.path.sep)[-1].split(':')[0]
On 2017/03/09 13:23:34, magjed_webrtc wrote:
> Can you add a comment giving an example input and output of this function?

Done.

[tkchin_webrtc, 2017-03-09 22:26:28]

awesome

lgtm

https://codereview.webrtc.org/2735173002/diff/150001/tools-webrtc/ios/build_i...
File tools-webrtc/ios/build_ios_libs.py (right):

https://codereview.webrtc.org/2735173002/diff/150001/tools-webrtc/ios/build_i...
tools-webrtc/ios/build_ios_libs.py:207: # Generate the license file.
Is this arch dependent? (Or is there a way to make sure that it is not arch
dependent?)

[kthelgason, 2017-03-10 09:29:21]

On 2017/03/09 22:26:28, tkchin_webrtc wrote:
> Is this arch dependent? (Or is there a way to make sure that it is not arch
> dependent?)

I changed the script to consider multiple gn dirs and use the union of all the
deps. 
Feel free to take a second look since there were a few changes.

[kjellander_webrtc, 2017-03-10 12:56:20]

lgtm

[kthelgason, 2017-03-13 14:37:37]

The CQ bit was checked by kthelgason@webrtc.org

[kthelgason, 2017-03-13 14:37:37]

The patchset sent to the CQ was uploaded after l-g-t-m from magjed@webrtc.org,
tkchin@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2735173002/#ps170001 (title:
"Make license generation consider all architectures")

[commit-bot: I haz the power, 2017-03-13 14:37:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-13 15:06:00]

CQ is committing da patch.

Bot data: {"patchset_id": 170001, "attempt_start_ts": 1489415857180700,
"parent_rev": "d7016848b9d13fec0d4e9ada4176776e90fd8dea", "commit_rev":
"96feb2ac1c2f0b3a477807db7a11d10eb5a138bd"}

[commit-bot: I haz the power, 2017-03-13 15:06:02]

Description was changed from

==========
Update licence generation script after GYP->GN migration.

BUG=webrtc:6372
==========

to

==========
Update licence generation script after GYP->GN migration.

BUG=webrtc:6372

Review-Url: https://codereview.webrtc.org/2735173002
Cr-Commit-Position: refs/heads/master@{#17212}
Committed:
https://chromium.googlesource.com/external/webrtc/+/96feb2ac1c2f0b3a477807db7...
==========

[commit-bot: I haz the power, 2017-03-13 15:06:03]

Committed patchset #10 (id:170001) as
https://chromium.googlesource.com/external/webrtc/+/96feb2ac1c2f0b3a477807db7...