Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 2734753004: Revert of Added large room scenario to full-stack tests. Added thumbnail streams functionality to call test/v… (Closed)

Created:
3 years, 9 months ago by ilnik
Modified:
3 years, 9 months ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Added large room scenario to full-stack tests. Added thumbnail streams functionality to call test/v… (patchset #8 id:140001 of https://codereview.webrtc.org/2730073002/ ) Reason for revert: webrtc_perf_tests crashes on android and windows due to too large test. Original issue's description: > Added large room scenario to full-stack tests. Added thumbnail streams functionality to video quality test. > > Changed simulcast full-stack tests to be 30fps instead of 50 to better reflect real usecases (expect all kind of perf metrics to improve). > > BUG=webrtc:7095 > > Review-Url: https://codereview.webrtc.org/2730073002 > Cr-Commit-Position: refs/heads/master@{#17068} > Committed: https://chromium.googlesource.com/external/webrtc/+/d8bd1b1d82aa0c1ceec901e99e1f30f9ed58cb77 TBR=sprang@webrtc.org,kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7095 Review-Url: https://codereview.webrtc.org/2734753004 Cr-Commit-Position: refs/heads/master@{#17071} Committed: https://chromium.googlesource.com/external/webrtc/+/bfb124596eb7a2e666aa7183aff80a50600d81c8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -258 lines) Patch
M webrtc/test/call_test.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/test/call_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/video/full_stack_tests.cc View 10 chunks +15 lines, -91 lines 0 comments Download
M webrtc/video/video_quality_test.h View 3 chunks +3 lines, -13 lines 0 comments Download
M webrtc/video/video_quality_test.cc View 9 chunks +8 lines, -152 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
ilnik
3 years, 9 months ago (2017-03-06 15:34:42 UTC) #2
Created Revert of Added large room scenario to full-stack tests. Added thumbnail
streams functionality to call test/v…

Powered by Google App Engine
This is Rietveld 408576698