Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 2734753003: Cleaning up full-stack simulcast tests and making them more realistic. (Closed)

Created:
3 years, 9 months ago by ilnik
Modified:
3 years, 9 months ago
Reviewers:
sprang_webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Cleaning up full-stack simulcast tests and making them more realistic. BUG=none Review-Url: https://codereview.webrtc.org/2734753003 Cr-Commit-Position: refs/heads/master@{#17093} Committed: https://chromium.googlesource.com/external/webrtc/+/566c43b5257b3afe806466bc8d095a6b595f8ff8

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase + cleanup latest changes from upstream #

Total comments: 2

Patch Set 4 : Fixing naming of constants. #

Patch Set 5 : rebase #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -132 lines) Patch
M webrtc/video/full_stack_tests.cc View 1 2 3 4 5 10 chunks +51 lines, -126 lines 0 comments Download
M webrtc/video/video_quality_test.h View 1 3 chunks +6 lines, -6 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (5 generated)
ilnik
3 years, 9 months ago (2017-03-06 10:32:25 UTC) #2
sprang_webrtc
lgtm https://codereview.webrtc.org/2734753003/diff/40001/webrtc/video/full_stack_tests.cc File webrtc/video/full_stack_tests.cc (right): https://codereview.webrtc.org/2734753003/diff/40001/webrtc/video/full_stack_tests.cc#newcode350 webrtc/video/full_stack_tests.cc:350: const VideoQualityTest::Params::Video kSimulcastVP9Video = { s/Simulcast/Svc
3 years, 9 months ago (2017-03-06 17:18:30 UTC) #3
ilnik
https://codereview.webrtc.org/2734753003/diff/40001/webrtc/video/full_stack_tests.cc File webrtc/video/full_stack_tests.cc (right): https://codereview.webrtc.org/2734753003/diff/40001/webrtc/video/full_stack_tests.cc#newcode350 webrtc/video/full_stack_tests.cc:350: const VideoQualityTest::Params::Video kSimulcastVP9Video = { On 2017/03/06 17:18:30, språng ...
3 years, 9 months ago (2017-03-07 09:32:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2734753003/100001
3 years, 9 months ago (2017-03-07 12:22:43 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 12:42:58 UTC) #10
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/external/webrtc/+/566c43b5257b3afe806466bc8...

Powered by Google App Engine
This is Rietveld 408576698