Revert of Improve testing of SRTP external auth code paths.

Revert of Improve testing of SRTP external auth code paths. (patchset #2 id:20001 of https://codereview.webrtc.org/2722423003/ )

Reason for revert:
Breaks compilation in FYI bots, e.g. here:
http://build.chromium.org/p/chromium.webrtc.fyi/builders/Win%20Builder/builds/9314

FAILED: obj/third_party/webrtc/pc/rtc_pc/channel.obj 
ninja -t msvc -e environment.x86 -- E:\b\c\goma_client/gomacc.exe "E:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\VC\bin\amd64_x86/cl.exe" /nologo /showIncludes /FC @obj/third_party/webrtc/pc/rtc_pc/channel.obj.rsp /c ../../third_party/webrtc/pc/channel.cc /Foobj/third_party/webrtc/pc/rtc_pc/channel.obj /Fd"obj/third_party/webrtc/pc/rtc_pc_cc.pdb"
e:\b\c\b\win_builder\src\third_party\webrtc\pc\channel.cc(176): error C2819: type 'cricket::SrtpFilter' does not have an overloaded member 'operator ->'
e:\b\c\b\win_builder\src\third_party\webrtc\pc\srtpfilter.h(45): note: see declaration of 'cricket::SrtpFilter'
e:\b\c\b\win_builder\src\third_party\webrtc\pc\channel.cc(176): note: did you intend to use '.' instead?
e:\b\c\b\win_builder\src\third_party\webrtc\pc\channel.cc(176): error C2232: '->cricket::SrtpFilter::EnableExternalAuth': left operand has 'class' type, use '.'

Original issue's description:
> Improve testing of SRTP external auth code paths.
> 
> Previously code behind ENABLE_EXTERNAL_AUTH was only compiled with Chromium
> but developed in WebRTC, which made testing rather complicated. This caused
> some trouble in the past (e.g. https://crbug.com/628400#c1)
> 
> This CL helps in that the external auth code is now compiled with WebRTC
> and the srtpfilter integration gets tested.
> 
> BUG=chromium:628400
> 
> Review-Url: https://codereview.webrtc.org/2722423003
> Cr-Commit-Position: refs/heads/master@{#17030}
> Committed: https://chromium.googlesource.com/external/webrtc/+/ac170d5c214e1f487ba82b888e5c3d5000118de0

TBR=deadbeef@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:628400
Review-Url: https://codereview.webrtc.org/2734643002
Cr-Commit-Position: refs/heads/master@{#17031}
Committed: https://chromium.googlesource.com/external/webrtc/+/d81f121cfa7d7ad5d66f461f97d647e1540bd0ac

[joachim, 2017-03-04 09:37:13]

The CQ bit was checked by jbauch@webrtc.org

[joachim, 2017-03-04 09:37:13]

Created Revert of Improve testing of SRTP external auth code paths.

[commit-bot: I haz the power, 2017-03-04 09:37:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-04 09:37:29]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1488620233375580, "parent_rev":
"ac170d5c214e1f487ba82b888e5c3d5000118de0", "commit_rev":
"d81f121cfa7d7ad5d66f461f97d647e1540bd0ac"}

[commit-bot: I haz the power, 2017-03-04 09:37:31]

Description was changed from

==========
Revert of Improve testing of SRTP external auth code paths. (patchset #2
id:20001 of https://codereview.webrtc.org/2722423003/ )

Reason for revert:
Breaks compilation in FYI bots, e.g. here:
http://build.chromium.org/p/chromium.webrtc.fyi/builders/Win%20Builder/builds...

FAILED: obj/third_party/webrtc/pc/rtc_pc/channel.obj 
ninja -t msvc -e environment.x86 -- E:\b\c\goma_client/gomacc.exe
"E:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\VC\bin\amd64_x86/cl.exe"
/nologo /showIncludes /FC @obj/third_party/webrtc/pc/rtc_pc/channel.obj.rsp /c
../../third_party/webrtc/pc/channel.cc
/Foobj/third_party/webrtc/pc/rtc_pc/channel.obj
/Fd"obj/third_party/webrtc/pc/rtc_pc_cc.pdb"
e:\b\c\b\win_builder\src\third_party\webrtc\pc\channel.cc(176): error C2819:
type 'cricket::SrtpFilter' does not have an overloaded member 'operator ->'
e:\b\c\b\win_builder\src\third_party\webrtc\pc\srtpfilter.h(45): note: see
declaration of 'cricket::SrtpFilter'
e:\b\c\b\win_builder\src\third_party\webrtc\pc\channel.cc(176): note: did you
intend to use '.' instead?
e:\b\c\b\win_builder\src\third_party\webrtc\pc\channel.cc(176): error C2232:
'->cricket::SrtpFilter::EnableExternalAuth': left operand has 'class' type, use
'.'

Original issue's description:
> Improve testing of SRTP external auth code paths.
> 
> Previously code behind ENABLE_EXTERNAL_AUTH was only compiled with Chromium
> but developed in WebRTC, which made testing rather complicated. This caused
> some trouble in the past (e.g. https://crbug.com/628400#c1)
> 
> This CL helps in that the external auth code is now compiled with WebRTC
> and the srtpfilter integration gets tested.
> 
> BUG=chromium:628400
> 
> Review-Url: https://codereview.webrtc.org/2722423003
> Cr-Commit-Position: refs/heads/master@{#17030}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/ac170d5c214e1f487ba82b888...

TBR=deadbeef@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:628400
==========

to

==========
Revert of Improve testing of SRTP external auth code paths. (patchset #2
id:20001 of https://codereview.webrtc.org/2722423003/ )

Reason for revert:
Breaks compilation in FYI bots, e.g. here:
http://build.chromium.org/p/chromium.webrtc.fyi/builders/Win%20Builder/builds...

FAILED: obj/third_party/webrtc/pc/rtc_pc/channel.obj 
ninja -t msvc -e environment.x86 -- E:\b\c\goma_client/gomacc.exe
"E:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\VC\bin\amd64_x86/cl.exe"
/nologo /showIncludes /FC @obj/third_party/webrtc/pc/rtc_pc/channel.obj.rsp /c
../../third_party/webrtc/pc/channel.cc
/Foobj/third_party/webrtc/pc/rtc_pc/channel.obj
/Fd"obj/third_party/webrtc/pc/rtc_pc_cc.pdb"
e:\b\c\b\win_builder\src\third_party\webrtc\pc\channel.cc(176): error C2819:
type 'cricket::SrtpFilter' does not have an overloaded member 'operator ->'
e:\b\c\b\win_builder\src\third_party\webrtc\pc\srtpfilter.h(45): note: see
declaration of 'cricket::SrtpFilter'
e:\b\c\b\win_builder\src\third_party\webrtc\pc\channel.cc(176): note: did you
intend to use '.' instead?
e:\b\c\b\win_builder\src\third_party\webrtc\pc\channel.cc(176): error C2232:
'->cricket::SrtpFilter::EnableExternalAuth': left operand has 'class' type, use
'.'

Original issue's description:
> Improve testing of SRTP external auth code paths.
> 
> Previously code behind ENABLE_EXTERNAL_AUTH was only compiled with Chromium
> but developed in WebRTC, which made testing rather complicated. This caused
> some trouble in the past (e.g. https://crbug.com/628400#c1)
> 
> This CL helps in that the external auth code is now compiled with WebRTC
> and the srtpfilter integration gets tested.
> 
> BUG=chromium:628400
> 
> Review-Url: https://codereview.webrtc.org/2722423003
> Cr-Commit-Position: refs/heads/master@{#17030}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/ac170d5c214e1f487ba82b888...

TBR=deadbeef@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:628400

Review-Url: https://codereview.webrtc.org/2734643002
Cr-Commit-Position: refs/heads/master@{#17031}
Committed:
https://chromium.googlesource.com/external/webrtc/+/d81f121cfa7d7ad5d66f461f9...
==========

[commit-bot: I haz the power, 2017-03-04 09:37:31]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/d81f121cfa7d7ad5d66f461f9...