Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(815)

Issue 2733863002: Conversational Speech generator, main script with shell arguments (Closed)

Created:
3 years, 9 months ago by AleBzk
Modified:
3 years, 9 months ago
Reviewers:
ivoc
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, Andrew MacDonald, aleloi, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Conversational Speech generator, main script with shell arguments BUG=webrtc:7218 NOTRY=True Review-Url: https://codereview.webrtc.org/2733863002 Cr-Commit-Position: refs/heads/master@{#17117} Committed: https://chromium.googlesource.com/external/webrtc/+/1d395dfb36e9ada73fc16aff09c4db3f3c3f17df

Patch Set 1 : python style #

Total comments: 1

Patch Set 2 : typo fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -12 lines) Patch
M webrtc/modules/audio_processing/test/py_conversational_speech/README.md View 2 chunks +22 lines, -12 lines 0 comments Download
A webrtc/modules/audio_processing/test/py_conversational_speech/generate_conversational_tracks.py View 1 1 chunk +58 lines, -0 lines 0 comments Download
A webrtc/modules/audio_processing/test/py_conversational_speech/test_generation.py View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
AleBzk
Hi Ivo, This is the 2nd CL for a new tool I'm making. Everything is ...
3 years, 9 months ago (2017-03-06 14:21:20 UTC) #5
ivoc
lgtm with one small nit. https://codereview.webrtc.org/2733863002/diff/40001/webrtc/modules/audio_processing/test/py_conversational_speech/generate_conversational_tracks.py File webrtc/modules/audio_processing/test/py_conversational_speech/generate_conversational_tracks.py (right): https://codereview.webrtc.org/2733863002/diff/40001/webrtc/modules/audio_processing/test/py_conversational_speech/generate_conversational_tracks.py#newcode13 webrtc/modules/audio_processing/test/py_conversational_speech/generate_conversational_tracks.py:13: Usage: generate_convsersational_tracks.py typo
3 years, 9 months ago (2017-03-08 13:15:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2733863002/60001
3 years, 9 months ago (2017-03-08 14:10:09 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 14:12:28 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/1d395dfb36e9ada73fc16aff0...

Powered by Google App Engine
This is Rietveld 408576698