Chromium Code Reviews

Issue 2733823002: Replace Clock::CurrentNtp with Clock::CurrentNtpTime (Closed)

Created:
3 years, 9 months ago by danilchap
Modified:
3 years, 9 months ago
Reviewers:
perkj_webrtc, stefan-webrtc
CC:
webrtc-reviews_webrtc.org, danilchap, zhuangzesen_agora.io, henrika_webrtc, zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, fengyue_agora.io, peah-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Replace Clock::CurrentNtp with Clock::CurrentNtpTime CurrentNtp return time by taking two output parameters by reference (also breaks style guide) CurrentNtpTime treat ntp time as single entity and returns it using NtpTime structure. (making interface clearer) BUG=None Review-Url: https://codereview.webrtc.org/2733823002 Cr-Commit-Position: refs/heads/master@{#17088} Committed: https://chromium.googlesource.com/external/webrtc/+/21dc1890f434b5f22011192e98b8460ffc9c36d2

Patch Set 1 #

Patch Set 2 : Remove CurrentNtp instead of deprecate #

Unified diffs Side-by-side diffs Stats (+24 lines, -41 lines)
M webrtc/modules/rtp_rtcp/source/remote_ntp_time_estimator_unittest.cc View 1 chunk +2 lines, -4 lines 0 comments
M webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc View 2 chunks +4 lines, -10 lines 0 comments
M webrtc/system_wrappers/include/clock.h View 2 chunks +4 lines, -8 lines 0 comments
M webrtc/system_wrappers/source/clock.cc View 3 chunks +9 lines, -13 lines 0 comments
M webrtc/test/drifting_clock.h View 1 chunk +1 line, -1 line 0 comments
M webrtc/test/drifting_clock.cc View 1 chunk +4 lines, -5 lines 0 comments

Messages

Total messages: 13 (8 generated)
danilchap
3 years, 9 months ago (2017-03-06 11:59:44 UTC) #6
perkj_webrtc
lgtm
3 years, 9 months ago (2017-03-06 19:37:40 UTC) #7
stefan-webrtc
lgtm
3 years, 9 months ago (2017-03-07 10:15:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2733823002/20001
3 years, 9 months ago (2017-03-07 10:20:08 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 10:51:12 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/21dc1890f434b5f22011192e9...

Powered by Google App Engine