Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2733803002: Fix segmentation fault in AudioEncoderOpusTest.EncodeAtMinBitrate. (Closed)

Created:
3 years, 9 months ago by michaelt
Modified:
3 years, 9 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix segmentation fault in AudioEncoderOpusTest.EncodeAtMinBitrate. BUG=webrtc:7105 Review-Url: https://codereview.webrtc.org/2733803002 Cr-Commit-Position: refs/heads/master@{#17069} Committed: https://chromium.googlesource.com/external/webrtc/+/e7811f5d698c1b04f32bae1c0e68f515d36a5e36

Patch Set 1 #

Patch Set 2 : Respond to comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus_unittest.cc View 1 2 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
michaelt
Hi, here the promised fix.
3 years, 9 months ago (2017-03-06 10:18:43 UTC) #3
hlundin-webrtc
LGTM! Thanks for fixing.
3 years, 9 months ago (2017-03-06 12:15:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2733803002/20001
3 years, 9 months ago (2017-03-06 14:27:09 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 14:49:31 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/e7811f5d698c1b04f32bae1c0...

Powered by Google App Engine
This is Rietveld 408576698