Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 2733773003: Fix iOS8 crash in background mode. (Closed)

Created:
3 years, 9 months ago by sdkdimon
Modified:
3 years, 9 months ago
Reviewers:
tkchin_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix iOS8 crash in background mode. Add system version check functionality in UIDevice+RTCDevice category. Check for iOS system version when handle capture session interruption. BUG=webrtc:7201 Review-Url: https://codereview.webrtc.org/2733773003 Cr-Commit-Position: refs/heads/master@{#17079} Committed: https://chromium.googlesource.com/external/webrtc/+/846e1be85c74897a8a335c8b24b0a1a354e62b6e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -15 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/RTCAVFoundationVideoCapturerInternal.mm View 2 chunks +18 lines, -15 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/UIDevice+RTCDevice.mm View 1 chunk +8 lines, -0 lines 0 comments Download
M webrtc/sdk/objc/Framework/Headers/WebRTC/UIDevice+RTCDevice.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
sdkdimon
Add system version check functionality in UIDevice+RTCDevice category. Check for iOS system version when handle ...
3 years, 9 months ago (2017-03-06 12:12:04 UTC) #2
tkchin_webrtc
On 2017/03/06 12:12:04, sdkdimon wrote: > Add system version check functionality in UIDevice+RTCDevice category. Check ...
3 years, 9 months ago (2017-03-07 00:18:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2733773003/1
3 years, 9 months ago (2017-03-07 00:19:28 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 00:42:23 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/846e1be85c74897a8a335c8b2...

Powered by Google App Engine
This is Rietveld 408576698