Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2732663004: Rename OnIceConnectionChange to OnIceConnectionStateChange for consistency with the WebRTC 1.0 stan… (Closed)

Created:
3 years, 9 months ago by Zach Stein
Modified:
3 years, 9 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Rename PeerConnection::OnIceConnectionChange to OnIceConnectionStateChange for consistency with the WebRTC 1.0 standard as suggested in a TODO. BUG=None Review-Url: https://codereview.webrtc.org/2732663004 Cr-Commit-Position: refs/heads/master@{#17077} Committed: https://chromium.googlesource.com/external/webrtc/+/6dfd53a81ee7c6ce4c6536f3adc930a3755b6385

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M webrtc/pc/peerconnection.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/pc/peerconnection.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/pc/webrtcsession.h View 1 chunk +1 line, -3 lines 0 comments Download
M webrtc/pc/webrtcsession.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/pc/webrtcsession_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (13 generated)
Zach Stein
3 years, 9 months ago (2017-03-04 06:58:13 UTC) #8
Taylor Brandstetter
lgtm. Could you add "BUG=None" and fit CL summary to 80 characters/1 line though? Also, ...
3 years, 9 months ago (2017-03-06 18:29:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2732663004/1
3 years, 9 months ago (2017-03-06 20:59:12 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 21:49:09 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/6dfd53a81ee7c6ce4c6536f3a...

Powered by Google App Engine
This is Rietveld 408576698