Ignore aud and sei NALus when parsing bitstream.

Ignore aud and sei NALus when parsing bitstream.

We currently don't know how to parse these NALus and we don't need
any information from them anyway so we might as well skip parsing them
and not break.

BUG=chromium:697795
Review-Url: https://codereview.webrtc.org/2732623002
Cr-Commit-Position: refs/heads/master@{#17057}
Committed: https://chromium.googlesource.com/external/webrtc/+/dea7f4f46f3d75eb01bad17537c3df2ce9ec4115

[kthelgason, 2017-03-03 10:33:30]

kthelgason@webrtc.org changed reviewers:
+ magjed@webrtc.org

[kthelgason, 2017-03-03 10:33:34]

The CQ bit was checked by kthelgason@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 10:33:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-03 10:57:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 10:57:15]

Dry run: This issue passed the CQ dry run.

[magjed_webrtc, 2017-03-03 12:59:00]

Is it easy to add an unittest for this?

[kthelgason, 2017-03-06 10:12:07]

On 2017/03/03 12:59:00, magjed_webrtc wrote:
> Is it easy to add an unittest for this?

Apparently not. The parser is designed to ignore errors to be resilient to
network data. There is no way to access the internal state of the parser from
the tests without changing it's design.

I feel like this change is small enough that it doesn't need testing to go in,
though at some point I would like to improve test coverage for the parser as a
whole.

[magjed_webrtc, 2017-03-06 10:18:21]

lgtm

[kthelgason, 2017-03-06 10:18:44]

The CQ bit was checked by kthelgason@webrtc.org

[commit-bot: I haz the power, 2017-03-06 10:18:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-06 10:49:37]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1488795524923900, "parent_rev":
"5571ee94653536596f7c04fb1e20eb050b4ae385", "commit_rev":
"dea7f4f46f3d75eb01bad17537c3df2ce9ec4115"}

[commit-bot: I haz the power, 2017-03-06 10:49:39]

Description was changed from

==========
Ignore aud and sei NALus when parsing bitstream.

We currently don't know how to parse these NALus and we don't need
any information from them anyway so we might as well skip parsing them
and not break.

BUG=chromium:697795
==========

to

==========
Ignore aud and sei NALus when parsing bitstream.

We currently don't know how to parse these NALus and we don't need
any information from them anyway so we might as well skip parsing them
and not break.

BUG=chromium:697795

Review-Url: https://codereview.webrtc.org/2732623002
Cr-Commit-Position: refs/heads/master@{#17057}
Committed:
https://chromium.googlesource.com/external/webrtc/+/dea7f4f46f3d75eb01bad1753...
==========

[commit-bot: I haz the power, 2017-03-06 10:49:40]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/dea7f4f46f3d75eb01bad1753...