Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Issue 2732443002: Go back to only using sched_yield on Mac (sigh) (Closed)

Created:
3 years, 9 months ago by tommi
Modified:
3 years, 9 months ago
Reviewers:
the sun
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Go back to only using sched_yield on Mac (sigh) Using sched_yield on Linux seems to be causing RestartingSendStreamPreservesRtpStatesWithRtx/0 to never complete. BUG=webrtc:7187 TBR=solenberg@webrtc.org Review-Url: https://codereview.webrtc.org/2732443002 Cr-Commit-Position: refs/heads/master@{#16975} Committed: https://chromium.googlesource.com/external/webrtc/+/0473b1dc03b045cda5869a7f43885243f233863b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M webrtc/base/platform_thread.cc View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
tommi
3 years, 9 months ago (2017-03-02 15:43:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2732443002/1
3 years, 9 months ago (2017-03-02 15:44:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/0473b1dc03b045cda5869a7f43885243f233863b
3 years, 9 months ago (2017-03-02 16:09:03 UTC) #8
the sun
3 years, 9 months ago (2017-03-02 16:54:14 UTC) #9
Message was sent while issue was closed.
sigh

lgtm

Powered by Google App Engine
This is Rietveld 408576698