Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(838)

Issue 2732423002: Enabling 'gn check' on all //webrtc/modules (Closed)

Created:
3 years, 9 months ago by mbonadei
Modified:
3 years, 9 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Enabling 'gn check' on all //webrtc/modules We can now use a wildcard and enable 'gn check' on all the targets in '//webrtc/modules'. Things are changed a lot since [1] and a refactoring [2] done by Edward has fixed the problem. We can now close [1] and enable 'gn check' on all the targets under '//webrtc/modules'. [1] - https://codereview.webrtc.org/2609443003/ [2] - https://chromium.googlesource.com/external/webrtc/+/9cbb0a16e5a02538dc9cb18ec9d447e2d2058ec BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2732423002 Cr-Commit-Position: refs/heads/master@{#17103} Committed: https://chromium.googlesource.com/external/webrtc/+/ffdd3d4176b38ed257d6516f8d4e1d4ff6b42cb3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -16 lines) Patch
M .gn View 1 chunk +1 line, -16 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
mbonadei
3 years, 9 months ago (2017-03-08 00:15:51 UTC) #3
kjellander_webrtc
That's excellent! I'll CQ this and keep an eye out for you. lgtm
3 years, 9 months ago (2017-03-08 06:39:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2732423002/1
3 years, 9 months ago (2017-03-08 06:39:40 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/ffdd3d4176b38ed257d6516f8d4e1d4ff6b42cb3
3 years, 9 months ago (2017-03-08 06:42:19 UTC) #11
mbonadei
On 2017/03/08 06:42:19, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as ...
3 years, 9 months ago (2017-03-09 07:50:41 UTC) #12
mbonadei
3 years, 9 months ago (2017-03-09 07:50:41 UTC) #13
Message was sent while issue was closed.
On 2017/03/08 06:42:19, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/external/webrtc/+/ffdd3d4176b38ed257d6516f8...

Thanks! :-)

Powered by Google App Engine
This is Rietveld 408576698