Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(746)

Issue 2732393003: Mac: fix screen capture freezes when context menu popup in Chrome. (Closed)

Created:
3 years, 9 months ago by braveyao1
Modified:
3 years, 9 months ago
Reviewers:
Sergey Ulanov, erikchen
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, erikchen
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Mac: fix screen capture freezes when context menu popup in Chrome. Previously we grab a run loop source and add a source with mode kCFRunLoopDefaultMode. With this mode, it won't callback when context menu popup (which needs the NSEventTrackingRunLoopMode), then screen capture can't get refreshed frame with context menu until the context menu is gone. The fix is to use kCFRunLoopComonModes, which includes default,modal and event tracking modes by default. BUG=chromium:697780 Review-Url: https://codereview.webrtc.org/2732393003 Cr-Commit-Position: refs/heads/master@{#17171} Committed: https://chromium.googlesource.com/external/webrtc/+/95b27217f204e9985e2c070abddc4aff4c8d7d35

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M webrtc/modules/desktop_capture/screen_capturer_mac.mm View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (14 generated)
braveyao1
Hi sergeyu@, please take a look.
3 years, 9 months ago (2017-03-08 20:19:33 UTC) #6
Sergey Ulanov
LGTM +erikchen in CC, FYI
3 years, 9 months ago (2017-03-10 01:13:23 UTC) #12
erikchen
lgtm
3 years, 9 months ago (2017-03-10 01:17:40 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2732393003/20001
3 years, 9 months ago (2017-03-10 17:44:38 UTC) #16
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 17:46:54 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/95b27217f204e9985e2c070ab...

Powered by Google App Engine
This is Rietveld 408576698