Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 2732193006: Make error reporting more detailed (Closed)

Created:
3 years, 9 months ago by kwiberg-webrtc
Modified:
3 years, 9 months ago
Reviewers:
nisse-webrtc
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make error reporting more detailed In an attempt to help Kenny locate the evil Dr. Deo. BUG=webrtc:7307 Review-Url: https://codereview.webrtc.org/2732193006 Cr-Commit-Position: refs/heads/master@{#17135} Committed: https://chromium.googlesource.com/external/webrtc/+/551e9848518fff9e76dd57ab236a4730b27439ac

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M webrtc/modules/audio_coding/codecs/isac/fix/test/kenny.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
kwiberg-webrtc
Please review carefully! I've been unable to trigger the error case locally.
3 years, 9 months ago (2017-03-09 09:12:31 UTC) #7
nisse-webrtc
LGTM.
3 years, 9 months ago (2017-03-09 09:24:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2732193006/1
3 years, 9 months ago (2017-03-09 10:06:13 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 10:08:32 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/551e9848518fff9e76dd57ab2...

Powered by Google App Engine
This is Rietveld 408576698