Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 2731993002: Update formatting of AudioLevel class (Closed)

Created:
3 years, 9 months ago by hlundin-webrtc
Modified:
3 years, 9 months ago
Reviewers:
the sun
CC:
webrtc-reviews_webrtc.org, AleBzk, henrika_webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Update formatting of AudioLevel class These changes are all no-op, only affecting the appearance of the code. The file names are changed to match the class name. BUG=none Review-Url: https://codereview.webrtc.org/2731993002 Cr-Commit-Position: refs/heads/master@{#17087} Committed: https://chromium.googlesource.com/external/webrtc/+/92a7a1810c0dd50c50d723621cfdddc8c721d0af

Patch Set 1 : Variable names changed and git cl format #

Patch Set 2 : Order of methods #

Patch Set 3 : Change file names #

Total comments: 4

Patch Set 4 : Review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -162 lines) Patch
M webrtc/voice_engine/BUILD.gn View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
A webrtc/voice_engine/audio_level.h View 1 2 3 1 chunk +52 lines, -0 lines 0 comments Download
A webrtc/voice_engine/audio_level.cc View 1 2 3 1 chunk +88 lines, -0 lines 0 comments Download
M webrtc/voice_engine/channel.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/level_indicator.h View 1 2 1 chunk +0 lines, -54 lines 0 comments Download
M webrtc/voice_engine/level_indicator.cc View 1 2 1 chunk +0 lines, -101 lines 0 comments Download
M webrtc/voice_engine/output_mixer.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/transmit_mixer.h View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
hlundin-webrtc
PTAL at this code beautification CL. I divided the changes into three separate steps, each ...
3 years, 9 months ago (2017-03-06 15:41:49 UTC) #5
the sun
lgtm % nits https://codereview.webrtc.org/2731993002/diff/80001/webrtc/voice_engine/audio_level.cc File webrtc/voice_engine/audio_level.cc (right): https://codereview.webrtc.org/2731993002/diff/80001/webrtc/voice_engine/audio_level.cc#newcode55 webrtc/voice_engine/audio_level.cc:55: abs_value = WebRtcSpl_MaxAbsValueW16( declare the int16_t ...
3 years, 9 months ago (2017-03-06 15:53:45 UTC) #6
hlundin-webrtc
Thanks! Will commit the new patch set. https://codereview.webrtc.org/2731993002/diff/80001/webrtc/voice_engine/audio_level.cc File webrtc/voice_engine/audio_level.cc (right): https://codereview.webrtc.org/2731993002/diff/80001/webrtc/voice_engine/audio_level.cc#newcode55 webrtc/voice_engine/audio_level.cc:55: abs_value = ...
3 years, 9 months ago (2017-03-07 09:35:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2731993002/100001
3 years, 9 months ago (2017-03-07 09:36:18 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 09:58:59 UTC) #13
Message was sent while issue was closed.
Committed patchset #4 (id:100001) as
https://chromium.googlesource.com/external/webrtc/+/92a7a1810c0dd50c50d723621...

Powered by Google App Engine
This is Rietveld 408576698