Add the option to disable IPv6 ICE candidates on WiFi

Add the option to disable IPv6 ICE candidates on WiFi.

Add an attribute to the RTCConfiguration which can be used by specific 
mobile devices so that the IPv6 ICE candidates on WiFi will not be collected.

BUG=b/35725283

Review-Url: https://codereview.webrtc.org/2731813002
Cr-Commit-Position: refs/heads/master@{#17100}
Committed: https://chromium.googlesource.com/external/webrtc/+/b09b3f9a6202e8bcbd8f3e12af1257a1d00cc5a0

[Zhi Huang, 2017-03-04 03:57:05]

zhihuang@webrtc.org changed reviewers:
+ deadbeef@webrtc.org

[Zhi Huang, 2017-03-04 03:57:05]

I haven't fully test this yet.
Please take a look. Thanks.

[Taylor Brandstetter, 2017-03-05 23:45:30]

Can you update the RTCConfiguration operator==? I think because it was a bool
inserted in the middle of the struct, my static_assert trick didn't catch it
being added.

https://codereview.webrtc.org/2731813002/diff/1/webrtc/api/peerconnectioninte...
File webrtc/api/peerconnectioninterface.h (right):

https://codereview.webrtc.org/2731813002/diff/1/webrtc/api/peerconnectioninte...
webrtc/api/peerconnectioninterface.h:335: // If set to true, don't gather IPv6
ICE candidates on WIFI.
nit: Spelled "Wi-Fi" or "WiFi"

https://codereview.webrtc.org/2731813002/diff/1/webrtc/api/peerconnectioninte...
webrtc/api/peerconnectioninterface.h:336: // This is only used on specifc
devices. Certain phones disable ipv6 when
nit: Instead of "only used", maybe "only intended to be used"? Also, "IPv6".

https://codereview.webrtc.org/2731813002/diff/1/webrtc/p2p/base/portallocator.h
File webrtc/p2p/base/portallocator.h (right):

https://codereview.webrtc.org/2731813002/diff/1/webrtc/p2p/base/portallocator...
webrtc/p2p/base/portallocator.h:77: // When specified, do not collect IPv6 ICE
candidate on WIFI.
nit: WIFI spelling, and "candidate" should be plural

https://codereview.webrtc.org/2731813002/diff/1/webrtc/p2p/client/basicportal...
File webrtc/p2p/client/basicportallocator.cc (right):

https://codereview.webrtc.org/2731813002/diff/1/webrtc/p2p/client/basicportal...
webrtc/p2p/client/basicportallocator.cc:616: // Skip IPv6 networks unless the
flag's been set.
nit: "Skip IPv6 WiFi networks"

https://codereview.webrtc.org/2731813002/diff/1/webrtc/pc/peerconnection.cc
File webrtc/pc/peerconnection.cc (right):

https://codereview.webrtc.org/2731813002/diff/1/webrtc/pc/peerconnection.cc#n...
webrtc/pc/peerconnection.cc:2521: LOG(LS_INFO) << "IPv6 candidates on WIFI are
disabled.";
nit: WIFI spelling

[Zhi Huang, 2017-03-06 19:35:03]

Description was changed from

==========
Add the option to disable IPv6 ICE candidates on Wifi.

BUG=b/35725283
==========

to

==========
Add the option to disable IPv6 ICE candidates on WiFi.

Add an attribute to the RTCConfiguration which can be used by specific 
mobile devices so that the IPv6 ICE candidates on WiFi will not be collected.

BUG=b/35725283
==========

[Zhi Huang, 2017-03-06 21:11:01]

Patchset #2 (id:20001) has been deleted

[Zhi Huang, 2017-03-06 21:14:18]

zhihuang@webrtc.org changed reviewers:
+ magjed@webrtc.org

[Zhi Huang, 2017-03-06 21:14:19]

Please take another look. 
Thanks.

https://codereview.webrtc.org/2731813002/diff/1/webrtc/api/peerconnectioninte...
File webrtc/api/peerconnectioninterface.h (right):

https://codereview.webrtc.org/2731813002/diff/1/webrtc/api/peerconnectioninte...
webrtc/api/peerconnectioninterface.h:335: // If set to true, don't gather IPv6
ICE candidates on WIFI.
On 2017/03/05 23:45:30, Taylor Brandstetter wrote:
> nit: Spelled "Wi-Fi" or "WiFi"

Done.

https://codereview.webrtc.org/2731813002/diff/1/webrtc/api/peerconnectioninte...
webrtc/api/peerconnectioninterface.h:336: // This is only used on specifc
devices. Certain phones disable ipv6 when
On 2017/03/05 23:45:30, Taylor Brandstetter wrote:
> nit: Instead of "only used", maybe "only intended to be used"? Also, "IPv6".

Done.

https://codereview.webrtc.org/2731813002/diff/1/webrtc/p2p/base/portallocator.h
File webrtc/p2p/base/portallocator.h (right):

https://codereview.webrtc.org/2731813002/diff/1/webrtc/p2p/base/portallocator...
webrtc/p2p/base/portallocator.h:77: // When specified, do not collect IPv6 ICE
candidate on WIFI.
On 2017/03/05 23:45:30, Taylor Brandstetter wrote:
> nit: WIFI spelling, and "candidate" should be plural

Done.

https://codereview.webrtc.org/2731813002/diff/1/webrtc/p2p/client/basicportal...
File webrtc/p2p/client/basicportallocator.cc (right):

https://codereview.webrtc.org/2731813002/diff/1/webrtc/p2p/client/basicportal...
webrtc/p2p/client/basicportallocator.cc:616: // Skip IPv6 networks unless the
flag's been set.
On 2017/03/05 23:45:30, Taylor Brandstetter wrote:
> nit: "Skip IPv6 WiFi networks"

Done.

https://codereview.webrtc.org/2731813002/diff/1/webrtc/pc/peerconnection.cc
File webrtc/pc/peerconnection.cc (right):

https://codereview.webrtc.org/2731813002/diff/1/webrtc/pc/peerconnection.cc#n...
webrtc/pc/peerconnection.cc:2521: LOG(LS_INFO) << "IPv6 candidates on WIFI are
disabled.";
On 2017/03/05 23:45:30, Taylor Brandstetter wrote:
> nit: WIFI spelling

Done.

[Taylor Brandstetter, 2017-03-07 16:48:21]

lgtm

https://codereview.webrtc.org/2731813002/diff/40001/webrtc/api/peerconnection...
File webrtc/api/peerconnectioninterface.h (right):

https://codereview.webrtc.org/2731813002/diff/40001/webrtc/api/peerconnection...
webrtc/api/peerconnectioninterface.h:336: // Only intended to be used on specifc
devices. Certain phones disable IPv6
nit: spelling of "specific"

[Zhi Huang, 2017-03-07 19:34:13]

zhihuang@webrtc.org changed reviewers:
+ glaznev@webrtc.org

[Zhi Huang, 2017-03-07 19:34:13]

Hi Alex,
This is a fix for the IPv6 ICE candidate related issue. Please take a look.
Thanks.

[AlexG, 2017-03-07 19:54:17]

lgtm

[Zhi Huang, 2017-03-07 19:54:39]

The CQ bit was checked by zhihuang@webrtc.org

[Zhi Huang, 2017-03-07 19:54:40]

The patchset sent to the CQ was uploaded after l-g-t-m from deadbeef@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2731813002/#ps60001 (title:
"Typo.")

[commit-bot: I haz the power, 2017-03-07 19:54:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-07 20:06:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 20:06:05]

Try jobs failed on following builders:
  linux_ubsan_vptr on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_ubsan_vptr/builds...)

[Zhi Huang, 2017-03-07 22:06:29]

The CQ bit was checked by zhihuang@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-07 22:06:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[Zhi Huang, 2017-03-07 22:33:01]

The CQ bit was unchecked by zhihuang@webrtc.org

[Zhi Huang, 2017-03-07 22:33:07]

The CQ bit was checked by zhihuang@webrtc.org

[Zhi Huang, 2017-03-07 22:33:07]

The patchset sent to the CQ was uploaded after l-g-t-m from glaznev@webrtc.org,
deadbeef@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2731813002/#ps80001 (title:
"Fix the rtc_unittests")

[commit-bot: I haz the power, 2017-03-07 22:33:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-07 22:40:52]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1488925987059840,
"parent_rev": "03e8af8babe2d8bbf2e58a7252f014a84976821b", "commit_rev":
"b09b3f9a6202e8bcbd8f3e12af1257a1d00cc5a0"}

[commit-bot: I haz the power, 2017-03-07 22:40:55]

Description was changed from

==========
Add the option to disable IPv6 ICE candidates on WiFi.

Add an attribute to the RTCConfiguration which can be used by specific 
mobile devices so that the IPv6 ICE candidates on WiFi will not be collected.

BUG=b/35725283
==========

to

==========
Add the option to disable IPv6 ICE candidates on WiFi.

Add an attribute to the RTCConfiguration which can be used by specific 
mobile devices so that the IPv6 ICE candidates on WiFi will not be collected.

BUG=b/35725283

Review-Url: https://codereview.webrtc.org/2731813002
Cr-Commit-Position: refs/heads/master@{#17100}
Committed:
https://chromium.googlesource.com/external/webrtc/+/b09b3f9a6202e8bcbd8f3e12a...
==========

[commit-bot: I haz the power, 2017-03-07 22:40:56]

Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/external/webrtc/+/b09b3f9a6202e8bcbd8f3e12a...