Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(783)

Issue 2731583003: Fixing a unittest to allow new Opus version. (Closed)

Created:
3 years, 9 months ago by minyue-webrtc
Modified:
3 years, 9 months ago
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fixing a unittest to allow new Opus version. New Opus version starts to support 120ms frame lengths. AudioEncoderOpusTest had an unnecessary check on the available frame lengths. It is removed in this CL. BUG=b/35415318 Review-Url: https://codereview.webrtc.org/2731583003 Cr-Commit-Position: refs/heads/master@{#17011} Committed: https://chromium.googlesource.com/external/webrtc/+/930ff23261b4cfd900a7c83ab7cbcff80d27fa6a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
minyue-webrtc
PTAL this small CL
3 years, 9 months ago (2017-03-03 14:18:49 UTC) #3
hlundin-webrtc
lgtm
3 years, 9 months ago (2017-03-03 14:27:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2731583003/1
3 years, 9 months ago (2017-03-03 14:30:05 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/930ff23261b4cfd900a7c83ab7cbcff80d27fa6a
3 years, 9 months ago (2017-03-03 15:34:56 UTC) #9
kjellander_webrtc
3 years, 9 months ago (2017-03-03 19:15:37 UTC) #10
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698