Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 2731423004: Add AppRTCMobileTestStubbedVideoIO to gn_isolate_map. (Closed)

Created:
3 years, 9 months ago by ehmaldonado_webrtc
Modified:
3 years, 9 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add AppRTCMobileTestStubbedVideoIO to gn_isolate_map. This will make it possible for the test to run on swarming bots. BUG=chromium:685222 R=kjellander@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/2731423004 Cr-Commit-Position: refs/heads/master@{#17113} Committed: https://chromium.googlesource.com/external/webrtc/+/41f8a88e4fb8070d0422d74920d29383c6777e21

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M tools-webrtc/mb/gn_isolate_map.pyl View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
ehmaldonado_webrtc
3 years, 9 months ago (2017-03-08 10:44:41 UTC) #3
kjellander_webrtc
lgtm don't forget NOTRY=True if you plan to use CQ
3 years, 9 months ago (2017-03-08 11:56:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2731423004/1
3 years, 9 months ago (2017-03-08 12:20:20 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 12:22:45 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/41f8a88e4fb8070d0422d7492...

Powered by Google App Engine
This is Rietveld 408576698