Fixed VP8 simulcast full-stack-tests to not decode non-selected streams.

Fixed VP8 simulcast full-stack-tests to not decode non-selected streams.

BUG=webrtc:7095
Review-Url: https://codereview.webrtc.org/2730433005
Cr-Commit-Position: refs/heads/master@{#16976}
Committed: https://chromium.googlesource.com/external/webrtc/+/9fd9f6c15f59b2be6a35ff1c7709810919b44766

[ilnik, 2017-03-02 14:03:24]

ilnik@webrtc.org changed reviewers:
+ sprang@webrtc.org

[sprang_webrtc, 2017-03-02 15:27:29]

lgtm with nits

https://codereview.webrtc.org/2730433005/diff/1/webrtc/video/video_quality_te...
File webrtc/video/video_quality_test.cc (right):

https://codereview.webrtc.org/2730433005/diff/1/webrtc/video/video_quality_te...
webrtc/video/video_quality_test.cc:1274: if (i != params_.ss.selected_stream) {
Maybe add a comment explaining what is going on here.

https://codereview.webrtc.org/2730433005/diff/1/webrtc/video/video_quality_te...
webrtc/video/video_quality_test.cc:1281:
std::unique_ptr<VideoDecoder>(decoder.decoder));
nit: you can even just do 
  allocated_decoders_.emplace_back(decoder.decoder);

[ilnik, 2017-03-02 15:37:20]

https://codereview.webrtc.org/2730433005/diff/1/webrtc/video/video_quality_te...
File webrtc/video/video_quality_test.cc (right):

https://codereview.webrtc.org/2730433005/diff/1/webrtc/video/video_quality_te...
webrtc/video/video_quality_test.cc:1274: if (i != params_.ss.selected_stream) {
On 2017/03/02 15:27:29, språng wrote:
> Maybe add a comment explaining what is going on here.

Done.

https://codereview.webrtc.org/2730433005/diff/1/webrtc/video/video_quality_te...
webrtc/video/video_quality_test.cc:1281:
std::unique_ptr<VideoDecoder>(decoder.decoder));
On 2017/03/02 15:27:29, språng wrote:
> nit: you can even just do 
>   allocated_decoders_.emplace_back(decoder.decoder);

Done.

[ilnik, 2017-03-02 15:37:36]

The CQ bit was checked by ilnik@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 15:37:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-02 16:06:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 16:06:15]

Dry run: This issue passed the CQ dry run.

[ilnik, 2017-03-02 16:07:39]

The CQ bit was checked by ilnik@webrtc.org

[ilnik, 2017-03-02 16:07:40]

The patchset sent to the CQ was uploaded after l-g-t-m from sprang@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2730433005/#ps20001 (title:
"Implemented Sprang@ comments")

[commit-bot: I haz the power, 2017-03-02 16:07:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-02 16:10:10]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488470859863220,
"parent_rev": "0473b1dc03b045cda5869a7f43885243f233863b", "commit_rev":
"9fd9f6c15f59b2be6a35ff1c7709810919b44766"}

[commit-bot: I haz the power, 2017-03-02 16:10:12]

Description was changed from

==========
Fixed VP8 simulcast full-stack-tests to not decode non-selected streams.

BUG=webrtc:7095
==========

to

==========
Fixed VP8 simulcast full-stack-tests to not decode non-selected streams.

BUG=webrtc:7095

Review-Url: https://codereview.webrtc.org/2730433005
Cr-Commit-Position: refs/heads/master@{#16976}
Committed:
https://chromium.googlesource.com/external/webrtc/+/9fd9f6c15f59b2be6a35ff1c7...
==========

[commit-bot: I haz the power, 2017-03-02 16:10:14]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/9fd9f6c15f59b2be6a35ff1c7...