Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2729903002: Increase kMinRequiredSamples (5 -> 200) for updating histogram stats from OnFrameBufferTimingsUpdat… (Closed)

Created:
3 years, 9 months ago by åsapersson
Modified:
3 years, 9 months ago
Reviewers:
philipel, stefan-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Increase kMinRequiredSamples (5 -> 200) for updating histogram stats from OnFrameBufferTimingsUpdated callback. Callback used to be reported periodically (each 1000ms) but is now reported per frame. BUG=webrtc:5514 Review-Url: https://codereview.webrtc.org/2729903002 Cr-Commit-Position: refs/heads/master@{#16977} Committed: https://chromium.googlesource.com/external/webrtc/+/a563c21e6a0c2912781c69d5be7c1be858cfc95b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -8 lines) Patch
M webrtc/video/receive_statistics_proxy.cc View 1 chunk +5 lines, -8 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
åsapersson
3 years, 9 months ago (2017-03-02 15:57:11 UTC) #5
philipel
lgtm
3 years, 9 months ago (2017-03-02 16:07:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2729903002/1
3 years, 9 months ago (2017-03-02 16:23:58 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 16:25:50 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/a563c21e6a0c2912781c69d5b...

Powered by Google App Engine
This is Rietveld 408576698