Add performance tracing for PlatformThread and parts of the video code.

Add performance tracing for PlatformThread and parts of the video code.

BUG=webrtc:7219
Review-Url: https://codereview.webrtc.org/2729783004
Cr-Commit-Position: refs/heads/master@{#17009}
Committed: https://chromium.googlesource.com/external/webrtc/+/db23ea69b63d3ff3d4c42565d9bd23261dd8f9e9

[tommi, 2017-03-03 10:15:41]

tommi@webrtc.org changed reviewers:
+ philipel@webrtc.org

[tommi, 2017-03-03 10:15:47]

The CQ bit was checked by tommi@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 10:15:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-03 10:34:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 10:34:43]

Dry run: This issue passed the CQ dry run.

[philipel, 2017-03-03 12:08:34]

https://codereview.webrtc.org/2729783004/diff/1/webrtc/modules/video_coding/f...
File webrtc/modules/video_coding/frame_buffer2.cc (right):

https://codereview.webrtc.org/2729783004/diff/1/webrtc/modules/video_coding/f...
webrtc/modules/video_coding/frame_buffer2.cc:59: TRACE_EVENT0("webrtc",
"FrameBuffer::NextFrame");
If tracing is done in interest of profiling performance then this trace wont
make much sense. Also, not sure if it matters, but this function is recursive
(line 152). :)

[tommi, 2017-03-03 13:07:58]

https://codereview.webrtc.org/2729783004/diff/1/webrtc/modules/video_coding/f...
File webrtc/modules/video_coding/frame_buffer2.cc (right):

https://codereview.webrtc.org/2729783004/diff/1/webrtc/modules/video_coding/f...
webrtc/modules/video_coding/frame_buffer2.cc:59: TRACE_EVENT0("webrtc",
"FrameBuffer::NextFrame");
On 2017/03/03 12:08:34, philipel wrote:
> If tracing is done in interest of profiling performance then this trace wont
> make much sense. Also, not sure if it matters, but this function is recursive
> (line 152). :)

Both wall clock time and cpu time are useful when profiling.  As is, depending
on the scenario, the thread can spend little or a lot of time sleeping, which is
useful information.  If you use chrome://tracing to look at the data, you'll see
for example that if you have 10 incoming streams, there will be 10 threads, all
of which will be sleeping (on my machine) about 27ms in this function, or close
to 1/10th of a frame, then waking up to decode a frame.

For the purposes of this entry, it doesn't matter if it's recursive, but it will
show up in the trace data when we hit that code path, which can be useful.

[philipel, 2017-03-03 13:51:26]

lgtm

[tommi, 2017-03-03 14:10:01]

The CQ bit was checked by tommi@webrtc.org

[commit-bot: I haz the power, 2017-03-03 14:10:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-03 14:12:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 14:12:19]

Failed to apply patch for webrtc/video/video_receive_stream.cc:
While running git apply --index -p1;
  error: patch failed: webrtc/video/video_receive_stream.cc:19
  error: webrtc/video/video_receive_stream.cc: patch does not apply

Patch:       webrtc/video/video_receive_stream.cc
Index: webrtc/video/video_receive_stream.cc
diff --git a/webrtc/video/video_receive_stream.cc
b/webrtc/video/video_receive_stream.cc
index
fbfdb2b67fc7df9d063945e8c9294f0dec461990..13ce8e4b339947629570e56bc390c4f29570366d
100644
--- a/webrtc/video/video_receive_stream.cc
+++ b/webrtc/video/video_receive_stream.cc
@@ -19,6 +19,7 @@
 #include "webrtc/base/checks.h"
 #include "webrtc/base/logging.h"
 #include "webrtc/base/optional.h"
+#include "webrtc/base/trace_event.h"
 #include "webrtc/common_video/h264/profile_level_id.h"
 #include "webrtc/common_video/libyuv/include/webrtc_libyuv.h"
 #include "webrtc/modules/rtp_rtcp/include/rtp_receiver.h"
@@ -472,6 +473,7 @@ bool VideoReceiveStream::DecodeThreadFunction(void* ptr) {
 }
 
 bool VideoReceiveStream::Decode() {
+  TRACE_EVENT0("webrtc", "VideoReceiveStream::Decode");
   static const int kMaxWaitForFrameMs = 3000;
   std::unique_ptr<video_coding::FrameObject> frame;
   video_coding::FrameBuffer::ReturnReason res =

[tommi, 2017-03-03 14:17:31]

Rebase

[tommi, 2017-03-03 14:18:00]

The CQ bit was checked by tommi@webrtc.org

[tommi, 2017-03-03 14:18:01]

The patchset sent to the CQ was uploaded after l-g-t-m from philipel@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2729783004/#ps20001 (title:
"Rebase")

[commit-bot: I haz the power, 2017-03-03 14:18:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-03 15:21:19]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488550680992560,
"parent_rev": "b4ec8765d8a61f2423364d2729670427bebb2518", "commit_rev":
"db23ea69b63d3ff3d4c42565d9bd23261dd8f9e9"}

[commit-bot: I haz the power, 2017-03-03 15:21:22]

Description was changed from

==========
Add performance tracing for PlatformThread and parts of the video code.

BUG=webrtc:7219
==========

to

==========
Add performance tracing for PlatformThread and parts of the video code.

BUG=webrtc:7219

Review-Url: https://codereview.webrtc.org/2729783004
Cr-Commit-Position: refs/heads/master@{#17009}
Committed:
https://chromium.googlesource.com/external/webrtc/+/db23ea69b63d3ff3d4c42565d...
==========

[commit-bot: I haz the power, 2017-03-03 15:21:23]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/db23ea69b63d3ff3d4c42565d...