Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2729133002: Make sure that ApmHelpersTest tests don't enter a tight loop. (Closed)

Created:
3 years, 9 months ago by tommi
Modified:
3 years, 9 months ago
Reviewers:
the sun
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make sure that ApmHelpersTest tests don't enter a tight loop. BUG=webrtc:7219, webrtc:7290 TBR=solenberg@webrtc.org Review-Url: https://codereview.webrtc.org/2729133002 Cr-Commit-Position: refs/heads/master@{#16996} Committed: https://chromium.googlesource.com/external/webrtc/+/f0d7b2b5077fd3fb655ea76b8b6e3c4b8ab8afef

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M webrtc/media/engine/apm_helpers_unittest.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
tommi
TBR-ing to fix the flakiness
3 years, 9 months ago (2017-03-03 09:14:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2729133002/1
3 years, 9 months ago (2017-03-03 09:15:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/f0d7b2b5077fd3fb655ea76b8b6e3c4b8ab8afef
3 years, 9 months ago (2017-03-03 09:34:19 UTC) #8
the sun
3 years, 9 months ago (2017-03-03 14:57:23 UTC) #9
Message was sent while issue was closed.
On 2017/03/03 09:34:19, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/external/webrtc/+/f0d7b2b5077fd3fb655ea76b8...

LGTM

Powered by Google App Engine
This is Rietveld 408576698